xfs
[Top] [All Lists]

Re: [PATCH 1/6] xfstests: generic/193 runs tests in wrong location

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/6] xfstests: generic/193 runs tests in wrong location
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 25 Jun 2013 14:49:20 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370610398-14630-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1370610398-14630-1-git-send-email-david@xxxxxxxxxxxxx> <1370610398-14630-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jun 07, 2013 at 11:06:33PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> generic/193 runs the test in $here - the root of the xfstests source
> tree/installation. IOWs, it doesn't test the filesystem on either
> the TEST_DIR or SCRATCH_MNT, and so it not testing the filesystem
> we think it is testing. Bad. Fixing this is the majority of the
> change - introducing $test_root and $test_user for the files with
> different owners, and then redirecting error output and filtering
> the output appropriately.
> 
> And then add checks that truncate clears the suid/sgid bits
> appropriately, somethign that has never been tested on XFS (and
> likely other filesystems) so will cause kernels between 3.1 and 3.9
> to assert fail as Dave Jones has recently reported.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.  The behavior you outlined regarding suid/sgid bits matches that of
should_remove_suid().

Reviewed-by: Ben Myers <bpm@xxxxxxx>

Applied.

<Prev in Thread] Current Thread [Next in Thread>