xfs
[Top] [All Lists]

Re: [PATCH 09/60] xfs: Inode create log items

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 09/60] xfs: Inode create log items
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Sat, 22 Jun 2013 10:49:44 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1371617468-32559-10-git-send-email-david@xxxxxxxxxxxxx>
References: <1371617468-32559-1-git-send-email-david@xxxxxxxxxxxxx> <1371617468-32559-10-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 06/18/13 23:50, Dave Chinner wrote:
+/*
+ * on disk log item structure
+ *
+ * Log recovery assumes the first two entries are the type and size and they 
fit
+ * in 32 bits. Also in host order (ugh) so they have to be 32 bit aligned so
+ * decoding can be done correctly.
+ */
+struct xfs_icreate_log {
+       __uint16_t      icl_type;       /* type of log format structure */
+       __uint16_t      icl_size;       /* size of log format structure */
+       __be32          icl_ag;         /* ag being allocated in */
+       __be32          icl_agbno;      /* start block of inode range */
+       __be32          icl_count;      /* number of inodes to initialise */
+       __be32          icl_isize;      /* size of inodes */
+       __be32          icl_length;     /* length of extent to initialise */
+       __be32          icl_gen;        /* inode generation number to use */
+};
+
+/* in memory log item structure */
+struct xfs_icreate_item {
+       struct xfs_log_item     ic_item;
+       struct xfs_icreate_log  ic_format;
+};
+

Just a nit: I assume the name was getting a bit long, but having _format in the name tells the structure purpose. I know, I know, the xfs_icreate_item uses format in the "ic_format" variable name.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>