xfs
[Top] [All Lists]

Re: [PATCH 06/60] xfs: xfs_ifree doesn't need to modify the inode buffer

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 06/60] xfs: xfs_ifree doesn't need to modify the inode buffer
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 21 Jun 2013 16:24:24 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1371617468-32559-7-git-send-email-david@xxxxxxxxxxxxx>
References: <1371617468-32559-1-git-send-email-david@xxxxxxxxxxxxx> <1371617468-32559-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 06/18/13 23:50, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

Long ago, bulkstat used to read inodes directly fromteh backing
buffer for speed. This had the unfortunate problem of being cache
incoherent with unlinks, and so xfs_ifree() had to mark the inode
as free directly in the backing buffer. bulkstat was changed some
time ago to use inode cache coherent lookups, and so will never see
unlinked inodes in it's lookups. Hence xfs_ifree() does not need to
touch the inode backing buffer anymore.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---
  fs/xfs/xfs_inode.c |   32 ++++----------------------------

looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>