Re: [PATCH 06/60] xfs: xfs_ifree doesn't need to modify the inode buffer

xfs

Re: [PATCH 06/60] xfs: xfs_ifree doesn't need to modify the inode buffer

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 06/60] xfs: xfs_ifree doesn't need to modify the inode buffer
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Fri, 21 Jun 2013 16:24:24 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1371617468-32559-7-git-send-email-david@xxxxxxxxxxxxx>
References:	<1371617468-32559-1-git-send-email-david@xxxxxxxxxxxxx> <1371617468-32559-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 06/18/13 23:50, Dave Chinner wrote:

From: Dave Chinner<dchinner@xxxxxxxxxx>

Long ago, bulkstat used to read inodes directly fromteh backing
buffer for speed. This had the unfortunate problem of being cache
incoherent with unlinks, and so xfs_ifree() had to mark the inode
as free directly in the backing buffer. bulkstat was changed some
time ago to use inode cache coherent lookups, and so will never see
unlinked inodes in it's lookups. Hence xfs_ifree() does not need to
touch the inode backing buffer anymore.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---
  fs/xfs/xfs_inode.c |   32 ++++----------------------------


looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 04/60] xfs: don't use speculative prealloc for small files, (continued) [PATCH 04/60] xfs: don't use speculative prealloc for small files, Dave Chinner Re: [PATCH 04/60] xfs: don't use speculative prealloc for small files, Brian Foster Re: [PATCH 04/60] xfs: don't use speculative prealloc for small files, Mark Tinguely [PATCH 07/60] xfs: Introduce ordered log vector support, Dave Chinner Re: [PATCH 07/60] xfs: Introduce ordered log vector support, Mark Tinguely [PATCH 08/60] xfs: Introduce an ordered buffer item, Dave Chinner Re: [PATCH 08/60] xfs: Introduce an ordered buffer item, Mark Tinguely [PATCH 09/60] xfs: Inode create log items, Dave Chinner Re: [PATCH 09/60] xfs: Inode create log items, Mark Tinguely [PATCH 06/60] xfs: xfs_ifree doesn't need to modify the inode buffer, Dave Chinner Re: [PATCH 06/60] xfs: xfs_ifree doesn't need to modify the inode buffer, Mark Tinguely <= [PATCH 10/60] xfs: Inode create transaction reservations, Dave Chinner Re: [PATCH 10/60] xfs: Inode create transaction reservations, Mark Tinguely [PATCH 11/60] xfs: Inode create item recovery, Dave Chinner Re: [PATCH 11/60] xfs: Inode create item recovery, Mark Tinguely [PATCH 12/60] xfs: Use inode create transaction, Dave Chinner Re: [PATCH 12/60] xfs: Use inode create transaction, Mark Tinguely [PATCH 17/60] xfs: split out attribute fork truncation code into separate file, Dave Chinner [PATCH 13/60] xfs: remove local fork format handling from xfs_bmapi_write(), Dave Chinner [PATCH 14/60] xfs: move getdents code into it's own file, Dave Chinner [PATCH 20/60] xfs: move xfs_getbmap to xfs_extent_ops.c, Dave Chinner

Previous by Date:	[PATCH] xfstests: make fs for 274 larger, Josef Bacik
Next by Date:	Manpower Recruitment from Vietnam, Viet Mn
Previous by Thread:	[PATCH 06/60] xfs: xfs_ifree doesn't need to modify the inode buffer, Dave Chinner
Next by Thread:	[PATCH 10/60] xfs: Inode create transaction reservations, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]