On Thu, Jun 20, 2013 at 07:34:17AM +1000, Dave Chinner wrote:
> I don't see any problem with doing that, though I would like to keep
> some of it separate - the dir2 stuff is complex enough that I would
> like to keep it separate, but stuff like all the log item format
> headers can be aggregated.
>
> How about we end up with xfs_log_format.h for the log and log item
> formats, xfs_da_format.h for all the dir2/da/attr format definitions,
> and xfs_format.h for everything else?
Sounds reasonable.
> > - any chance to reorder the inode.c split so that stuff doesn't get
> > move around multiple times?
>
> I was waiting for that question - I have been considering doing that
> but I've been putting it off because it is a fair bit of shuffling
> that I'd have to do from scratch. Sounds like another vote for :redo
> it"...
Maybe wait for the discussion about having the trans stuff and the
separate project quotas to go in before this, as it would mean another
big redo..
|