[Top] [All Lists]

Re: [PATCH v3 1/2] xfs: Remove XFS_MOUNT_RETERR

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH v3 1/2] xfs: Remove XFS_MOUNT_RETERR
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 19 Jun 2013 14:55:06 -0500
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, Mark Tinguely <tinguely@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51824DB3.9050904@xxxxxxxxxx>
References: <51824DB3.9050904@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Thu, May 02, 2013 at 07:27:47PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> XFS_MOUNT_RETERR is going to be set at xfs_parseargs() if
> mp->m_dalign is enabled, so any time we enter "if (mp->m_dalign)"
> branch in xfs_update_alignment(), XFS_MOUNT_RETERR is set and so
> we always be emitting a warning and returning an error.
> Hence, we can remove it and get rid of a couple of redundant
> check up against it at xfs_upate_alignment().
> Thanks Dave Chinner for the suggestions of simplify the code
> in xfs_parseargs().
> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
> Cc: Dave Chinner <dchinner@xxxxxxxxxx>
> Cc: Mark Tinguely <tinguely@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH v3 1/2] xfs: Remove XFS_MOUNT_RETERR, Ben Myers <=