xfs
[Top] [All Lists]

Re: [PATCH] xfs: Remove two dead transaction log reservaion macros

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: Remove two dead transaction log reservaion macros
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 19 Jun 2013 14:27:01 -0500
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51836A1F.2020804@xxxxxxxxxx>
References: <51836A1F.2020804@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, May 03, 2013 at 03:41:19PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> Upstream commit 5b292ae3a951a58e32119d73c7ac8f5bec7395a3
>       xfs: make use of xfs_calc_buf_res() in xfs_trans.c
> 
> Beginning from above commit, neither XFS_ALLOCFREE_LOG_RES() nor
> XFS_DIROP_LOG_RES() is used by those routines for calculating
> transaction space reservations, so it's safe to remove them now.
> 
> Also, with a slightly update for the relevant comments to reflect
> the ideas of why those log count numbers should be.
> 
> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>

Looks good.  Applied.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] xfs: Remove two dead transaction log reservaion macros, Ben Myers <=