xfs
[Top] [All Lists]

Re: [PATCH 29/60] xfs: consolidate xfs_utils.c

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 29/60] xfs: consolidate xfs_utils.c
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 19 Jun 2013 02:40:28 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1371617468-32559-30-git-send-email-david@xxxxxxxxxxxxx>
References: <1371617468-32559-1-git-send-email-david@xxxxxxxxxxxxx> <1371617468-32559-30-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> +/*
> + * Allocates a new inode from disk and return a pointer to the
> + * incore copy. This routine will internally commit the current
> + * transaction and allocate a new one if the Space Manager needed
> + * to do an allocation to replenish the inode free-list.
> + *
> + * This routine is designed to be called from xfs_create and
> + * xfs_create_dir.

xfs_create_dir is long gone.  I suspect it's best to just kill that
sentence.

> +/*
> + * Decrement the link count on an inode & log the change.
> + * If this causes the link count to go to zero, initiate the
> + * logging activity required to truncate a file.
> + */
> +int                          /* error */
> +xfs_droplink(

Can be static now.

> +/*
> + * Increment the link count on an inode & log the change.
> + */
> +int
> +xfs_bumplink(

Same here.

<Prev in Thread] Current Thread [Next in Thread>