| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 00/60] xfs: patch queue for 3.11 |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 19 Jun 2013 02:15:38 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1371617468-32559-1-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1371617468-32559-1-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
Hi Dave, I like this version a lot better from a quick glance. A few more comments: - do we really want all that many separate _format.h headers? I'd be really tempted to say we have just a single xfs_format.h header, which should declare everything. It's still not all that large, and it would be a really good start to ease our include mess. - xfs_extent_ops.c still has that odd _ops.c name I hate because it tends to imply it's an implementation of some ops vector. How about xfs_alloc_util.c to go with the other _util name you added? - any chance to reorder the inode.c split so that stuff doesn't get move around multiple times? |
| Previous by Date: | [PATCH] xfstests: add 'check -btrfs' support, Wang Sheng-Hui |
|---|---|
| Next by Date: | Re: [PATCH 29/60] xfs: consolidate xfs_utils.c, Christoph Hellwig |
| Previous by Thread: | [PATCH 50/60] xfs: create xfs_bmap_util.[ch], Dave Chinner |
| Next by Thread: | Re: [PATCH 00/60] xfs: patch queue for 3.11, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |