| To: | Dave Kleikamp <dave.kleikamp@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests: aio-stress is calling pthread_join incorrectly |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 19 Jun 2013 09:13:14 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <51C0E5BC.6060809@xxxxxxxxxx> |
| References: | <51C0E5BC.6060809@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Jun 18, 2013 at 05:57:00PM -0500, Dave Kleikamp wrote: > The retval parameter to pthread_join() is a pointer to a pointer. > aio-stress is passing in a pointer to an int. This can result in a bus > error on sparc64 when the pointer is not aligned on a 64-bit boundary. > Since the return value is not used, it is simplest to pass a NULL > pointer instead. > > This has been fixed in the LTP source: > https://github.com/linux-test-project/ltp/commit/981d33aad3b33c4625b88990fbf2fad5470d47e0 > > Signed-off-by: Dave Kleikamp <dave.kleikamp@xxxxxxxxxx> Looks good. Thanks, Shaggy. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | WANTED: xfstests results in different architectures, Chandra Seetharaman |
|---|---|
| Next by Date: | Re: deadlock with &log->l_cilp->xc_ctx_lock semaphone, Chandra Seetharaman |
| Previous by Thread: | [PATCH] xfstests: aio-stress is calling pthread_join incorrectly, Dave Kleikamp |
| Next by Thread: | Re: [PATCH] xfstests: aio-stress is calling pthread_join incorrectly, Ben Myers |
| Indexes: | [Date] [Thread] [Top] [All Lists] |