xfs
[Top] [All Lists]

Re: [PATCH v4] xfs: fix the symbolic link assert in xfs_ifree

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH v4] xfs: fix the symbolic link assert in xfs_ifree
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 19 Jun 2013 07:38:10 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130617203503.472644581@xxxxxxx>
References: <20130617203503.472644581@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jun 17, 2013 at 03:35:57PM -0500, Mark Tinguely wrote:
> a
> Content-Disposition: inline; filename=v4-xfs-fix-assert-in-xfs_ifree.patch
> 
> Adding an extended attribute to a symbolic link can force that
> link to an remote extent. xfs_inactive() incorrectly assumes
> that any symbolic link small enough to be in the inode core
> is incore, resulting in the remote extent to not be removed.
> xfs_ifree() will assert on presence of this leaked remote extent.
> 
> Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

One minor, minor thing:

> +     if (pathlen < 0 || pathlen > MAXPATHLEN) {
> +             xfs_alert(mp, "%s: inode (%llx) bad symlink length (%d)",

                                        (0x%llx)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>