xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix sgid inheritance for subdirectories inheriting defa

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix sgid inheritance for subdirectories inheriting default acls
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 17 Jun 2013 22:57:09 -0700
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Carlos Maiolino <cmaiolino@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130618055351.GR29338@dastard>
References: <1371238877-5722-1-git-send-email-cmaiolino@xxxxxxxxxx> <20130618044931.GQ29338@dastard> <20130618045529.GA20365@xxxxxxxxxxxxx> <20130618055351.GR29338@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jun 18, 2013 at 03:53:51PM +1000, Dave Chinner wrote:
> > I'd rather opencode updating the mode here, it's really just a tiny bit
> > of boilerplate code.
> 
> Needs a transaction, though. Right now, there's no transaction code
> at all in xfs_acl.c and I'd kind of like to keep it that way as it's
> just a translation layer....

True.  Maybe as a quick hack just extend the meaning of XFS_ATTR_NOACL
to also not do the checks?  It's already the magic flag to mean that
we are called from the ACL code.

Alternatively move all of xfs_set_mode, or at least everything around
the "if (mode != inode->i_mode) " to xfs_iops.c.

<Prev in Thread] Current Thread [Next in Thread>