xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix sgid inheritance for subdirectories inheriting defa

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix sgid inheritance for subdirectories inheriting default acls
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 18 Jun 2013 15:53:51 +1000
Cc: Carlos Maiolino <cmaiolino@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130618045529.GA20365@xxxxxxxxxxxxx>
References: <1371238877-5722-1-git-send-email-cmaiolino@xxxxxxxxxx> <20130618044931.GQ29338@dastard> <20130618045529.GA20365@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jun 17, 2013 at 09:55:29PM -0700, Christoph Hellwig wrote:
> On Tue, Jun 18, 2013 at 02:49:31PM +1000, Dave Chinner wrote:
> >     xfs_set_mode()
> >     {
> >             setup iattr
> >             return xfs_setattr_nonsize_nomodecheck()
> >     }
> 
> I'd rather opencode updating the mode here, it's really just a tiny bit
> of boilerplate code.

Needs a transaction, though. Right now, there's no transaction code
at all in xfs_acl.c and I'd kind of like to keep it that way as it's
just a translation layer....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>