xfs
[Top] [All Lists]

[PATCH v2] xfstest: ensure small symlink is removed

To: xfs@xxxxxxxxxxx
Subject: [PATCH v2] xfstest: ensure small symlink is removed
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 17 Jun 2013 20:35:05 -0500
Delivered-to: xfs@xxxxxxxxxxx
User-agent: quilt/0.60-1
a
Content-Disposition: inline; 
filename=xfstest-ensure-small-symlink-is-removed.patch

Tests the XFS symlinks that are small enough to be in the
inode, but were move to a remote symlink due to an extended
attribute were correctly removed.

Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>

---
v2
   change loop variable. added quick group.

   kept it xfs specific and using xfs_db so the failure is detected
   for non-debug kernels.

 tests/xfs/298     |   91 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/xfs/298.out |   63 +++++++++++++++++++++++++++++++++++++
 tests/xfs/group   |    1 
 3 files changed, 155 insertions(+)

Index: b/tests/xfs/298
===================================================================
--- /dev/null
+++ b/tests/xfs/298
@@ -0,0 +1,91 @@
+#! /bin/bash
+# FS QA Test No. 298
+#
+# Test that inline symlinks are removed from the inode when an extended
+# attributes forces it into being remote symlink.
+# Warning: this test will ASSERT on unpatched DEBUG XFS.
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2013 SGI.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1       # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+    cd /
+    rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# real QA test starts here
+
+# Modify as appropriate. This is a XFS specific bug. xfs_db also limits
+# this test to xfs
+_supported_fs xfs
+_supported_os Linux
+
+_require_scratch
+
+rm -f $seqres.full
+_scratch_mkfs_xfs >/dev/null 2>&1
+
+SYMLINK_FILE="$SCRATCH_MNT/symlink"
+SYMLINK=""
+SYMLINK_ADD="0123456789ABCDEF01234567890ABCDEF"
+
+# test from 32 to MAXPATHLEN sized symlink. This should make sure that
+# 256-1024 byte version 2 and 3 inodes are covered.
+SIZE=32
+while [ $SIZE -lt 1024 ];do
+       _scratch_mount >/dev/null 2>&1
+       cd $SCRATCH_MNT
+       echo "Testing symlink size $SIZE"
+       SYMLINK="${SYMLINK}${SYMLINK_ADD}"
+       ln -s $SYMLINK $SYMLINK_FILE > /dev/null 2>&1
+
+       inode=`ls -li $SYMLINK_FILE | awk '{print $1}'`
+# add the extended attributes
+       attr  -Rs 1234567890ab $SYMLINK_FILE < /dev/null > /dev/null 2>&1
+       attr  -Rs 1234567890ac $SYMLINK_FILE < /dev/null > /dev/null 2>&1
+       attr  -Rs 1234567890ad $SYMLINK_FILE < /dev/null > /dev/null 2>&1
+# remove the extended attributes
+       attr  -Rr 1234567890ab $SYMLINK_FILE > /dev/null 2>&1
+       attr  -Rr 1234567890ac $SYMLINK_FILE > /dev/null 2>&1
+       attr  -Rr 1234567890ad $SYMLINK_FILE > /dev/null 2>&1
+# remove the symlink - make sure ifree removes the remote symlink.
+       rm $SYMLINK_FILE
+# umount and check the number of extents on the inode. Should be 0.
+       cd
+       _scratch_unmount >/dev/null 2>&1
+       $XFS_DB_PROG  -c "inode $inode" -c "p core.nextents" $SCRATCH_DEV
+
+       let SIZE=$SIZE+32
+done
+
+status=0
+exit
Index: b/tests/xfs/298.out
===================================================================
--- /dev/null
+++ b/tests/xfs/298.out
@@ -0,0 +1,63 @@
+QA output created by 298
+Testing symlink size 32
+core.nextents = 0
+Testing symlink size 64
+core.nextents = 0
+Testing symlink size 96
+core.nextents = 0
+Testing symlink size 128
+core.nextents = 0
+Testing symlink size 160
+core.nextents = 0
+Testing symlink size 192
+core.nextents = 0
+Testing symlink size 224
+core.nextents = 0
+Testing symlink size 256
+core.nextents = 0
+Testing symlink size 288
+core.nextents = 0
+Testing symlink size 320
+core.nextents = 0
+Testing symlink size 352
+core.nextents = 0
+Testing symlink size 384
+core.nextents = 0
+Testing symlink size 416
+core.nextents = 0
+Testing symlink size 448
+core.nextents = 0
+Testing symlink size 480
+core.nextents = 0
+Testing symlink size 512
+core.nextents = 0
+Testing symlink size 544
+core.nextents = 0
+Testing symlink size 576
+core.nextents = 0
+Testing symlink size 608
+core.nextents = 0
+Testing symlink size 640
+core.nextents = 0
+Testing symlink size 672
+core.nextents = 0
+Testing symlink size 704
+core.nextents = 0
+Testing symlink size 736
+core.nextents = 0
+Testing symlink size 768
+core.nextents = 0
+Testing symlink size 800
+core.nextents = 0
+Testing symlink size 832
+core.nextents = 0
+Testing symlink size 864
+core.nextents = 0
+Testing symlink size 896
+core.nextents = 0
+Testing symlink size 928
+core.nextents = 0
+Testing symlink size 960
+core.nextents = 0
+Testing symlink size 992
+core.nextents = 0
Index: b/tests/xfs/group
===================================================================
--- a/tests/xfs/group
+++ b/tests/xfs/group
@@ -177,3 +177,4 @@
 295 auto logprint quick
 296 dump auto quick
 297 auto freeze
+298 auto attr symlink quick


<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH v2] xfstest: ensure small symlink is removed, Mark Tinguely <=