xfs
[Top] [All Lists]

Re: [PATCH 27/27] xfs: fix issues that cause userspace warnings

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 27/27] xfs: fix issues that cause userspace warnings
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Mon, 17 Jun 2013 15:32:23 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1371032567-21772-28-git-send-email-david@xxxxxxxxxxxxx>
References: <1371032567-21772-1-git-send-email-david@xxxxxxxxxxxxx> <1371032567-21772-28-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6
On 06/12/2013 06:22 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Some of the code shared with userspace causes compilation warnings
> from things turned off in the kernel code, such as differences in
> variable signedness. Fix those issues.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_attr_remote.c |    8 ++++----
>  fs/xfs/xfs_bmap.c        |    3 ---
>  fs/xfs/xfs_da_btree.c    |    6 +++---
>  fs/xfs/xfs_dir2_node.c   |    2 ++
>  fs/xfs/xfs_ialloc.c      |    2 +-
>  fs/xfs/xfs_rtalloc.c     |    4 ++--
>  6 files changed, 12 insertions(+), 13 deletions(-)
> 
...
>  
> diff --git a/fs/xfs/xfs_ialloc.c b/fs/xfs/xfs_ialloc.c
> index 319d9e4..9831eff 100644
> --- a/fs/xfs/xfs_ialloc.c
> +++ b/fs/xfs/xfs_ialloc.c
> @@ -1342,7 +1342,7 @@ xfs_imap(
>       xfs_agblock_t   cluster_agbno;  /* first block in inode cluster */
>       int             error;  /* error code */
>       int             offset; /* index of inode in its buffer */
> -     int             offset_agbno;   /* blks from chunk start to inode */
> +     xfs_agino_t     offset_agbno;   /* blks from chunk start to inode */

xfs_agblock_t ?

Brian

>       ASSERT(ino != NULLFSINO);
>  
> diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
> index 98dc670..c9a9a42 100644
> --- a/fs/xfs/xfs_rtalloc.c
> +++ b/fs/xfs/xfs_rtalloc.c
> @@ -736,8 +736,8 @@ xfs_rtallocate_range(
>  {
>       xfs_rtblock_t   end;            /* end of the allocated extent */
>       int             error;          /* error value */
> -     xfs_rtblock_t   postblock;      /* first block allocated > end */
> -     xfs_rtblock_t   preblock;       /* first block allocated < start */
> +     xfs_rtblock_t   postblock = 0;  /* first block allocated > end */
> +     xfs_rtblock_t   preblock = 0;   /* first block allocated < start */
>  
>       end = start + len - 1;
>       /*
> 

<Prev in Thread] Current Thread [Next in Thread>