xfs
[Top] [All Lists]

Re: [PATCH 15/27] xfs: reshuffle dir2 definitions around for userspace

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 15/27] xfs: reshuffle dir2 definitions around for userspace
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 17 Jun 2013 09:05:15 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1371032567-21772-16-git-send-email-david@xxxxxxxxxxxxx>
References: <1371032567-21772-1-git-send-email-david@xxxxxxxxxxxxx> <1371032567-21772-16-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jun 12, 2013 at 08:22:35PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Many of the definitions within xfs_dir2_priv.h are needed in
> userspace outside libxfs. Definitions within xfs_dir2_priv.h are
> wholly contained within libxfs, so we need to shuffle some of the
> definitions around to keep consistency across files shared between
> user and kernel space.

I created the xfs_dir2_format.h header so that it would be self
contained.  Despite not mentioning it in the description this patch
also moves typedefs out of xfs_dir2_format.h which is something I'd
rather avoid.  Where in userspace would we need these defintions but
can't include xfs_dir2_format.h?

<Prev in Thread] Current Thread [Next in Thread>