Re: [PATCH 15/27] xfs: reshuffle dir2 definitions around for userspace

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 15/27] xfs: reshuffle dir2 definitions around for userspace
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 17 Jun 2013 09:05:15 -0700
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1371032567-21772-16-git-send-email-david@xxxxxxxxxxxxx>
References:	<1371032567-21772-1-git-send-email-david@xxxxxxxxxxxxx> <1371032567-21772-16-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Jun 12, 2013 at 08:22:35PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Many of the definitions within xfs_dir2_priv.h are needed in
> userspace outside libxfs. Definitions within xfs_dir2_priv.h are
> wholly contained within libxfs, so we need to shuffle some of the
> definitions around to keep consistency across files shared between
> user and kernel space.

I created the xfs_dir2_format.h header so that it would be self
contained.  Despite not mentioning it in the description this patch
also moves typedefs out of xfs_dir2_format.h which is something I'd
rather avoid.  Where in userspace would we need these defintions but
can't include xfs_dir2_format.h?

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 02/27] xfs: add pluging for bulkstat readahead, (continued) [PATCH 02/27] xfs: add pluging for bulkstat readahead, Dave Chinner [PATCH 07/27] xfs: Introduce ordered log vector support, Dave Chinner [PATCH 06/27] xfs: xfs_ifree doesn't need to modify the inode buffer, Dave Chinner [PATCH 10/27] xfs: Inode create transaction reservations, Dave Chinner [PATCH 09/27] xfs: Inode create log items, Dave Chinner [PATCH 11/27] xfs: Inode create item recovery, Dave Chinner [PATCH 13/27] xfs: remove local fork format handling from xfs_bmapi_write(), Dave Chinner [PATCH 16/27] xfs: split out attribute listing code into separate file, Dave Chinner [PATCH 08/27] xfs: Introduce an ordered buffer item, Dave Chinner [PATCH 15/27] xfs: reshuffle dir2 definitions around for userspace, Dave Chinner Re: [PATCH 15/27] xfs: reshuffle dir2 definitions around for userspace, Christoph Hellwig <= Re: [PATCH 15/27] xfs: reshuffle dir2 definitions around for userspace, Dave Chinner Re: [PATCH 15/27] xfs: reshuffle dir2 definitions around for userspace, Dave Chinner [PATCH 20/27] xfs: move xfs_getbmap to xfs_extent_ops.c, Dave Chinner [PATCH 17/27] xfs: split out attribute fork truncation code into separate file, Dave Chinner [PATCH 12/27] xfs: Use inode create transaction, Dave Chinner [PATCH 23/27] xfs: sync minor header differences needed by userspace., Dave Chinner [PATCH 14/27] xfs: move getdents code into it's own file, Dave Chinner [PATCH 22/27] xfs: move xfs_trans_reservations to xfs_trans.h, Dave Chinner [PATCH 21/27] xfs: introduce xfs_sb.c for sharing with libxfs, Dave Chinner [PATCH 24/27] xfs: move xfs_bmap_punch_delalloc() to xfs_aops.c, Dave Chinner

Previous by Date:	Re: [PATCH 19/27] xfs: consolidate xfs_vnodeops.c into xfs_inode_ops.c, Christoph Hellwig
Next by Date:	Re: [PATCH 18/27] xfs: split out xfs inode operations into separate file, Ben Myers
Previous by Thread:	[PATCH 15/27] xfs: reshuffle dir2 definitions around for userspace, Dave Chinner
Next by Thread:	Re: [PATCH 15/27] xfs: reshuffle dir2 definitions around for userspace, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]