[Top] [All Lists]

Re: [PATCH 18/27] xfs: split out xfs inode operations into separate file

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 18/27] xfs: split out xfs inode operations into separate file
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 17 Jun 2013 08:56:44 -0700
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130613080009.GL29338@dastard>
References: <1371032567-21772-1-git-send-email-david@xxxxxxxxxxxxx> <1371032567-21772-19-git-send-email-david@xxxxxxxxxxxxx> <20130612140519.GB28988@xxxxxxxxxxxxx> <20130613011414.GB29338@dastard> <20130613080009.GL29338@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jun 13, 2013 at 06:00:09PM +1000, Dave Chinner wrote:
> So what I really think needs to happen here first is similar to the
> dir2 header file re-org. That is, a header file to define the
> format, and a header file to define the in-kernel structures and
> APIs....

Yes, I think we need to do this rather sooner than later.  In fact
I'd feeling we need to tackle the whole header mess first before
splitting the .c files.  Making sure the on-disk format is in one
or just a few headers is the most important bit of that.

These days I'm actually of the opinion that we probably should be
even more drastic about cutting the number of headers.  For the
on disk format a xfs_format.h for all the regular on disk format and
maybe and xfs_log_format.h should be more than enough.

But back to the _ops.c naming.  I really hate it and the best counter
proposals I can come up with is to add a _common postfix to every file
intended to be shared with userspace.  Using a directly also would make
sense, but for some reason Kbuild always had problems with modules built
from multiple directories and I'm more than glad that we finally managed
to get rid of the subdirectories.

<Prev in Thread] Current Thread [Next in Thread>