xfs
[Top] [All Lists]

Re: [PATCH 00/27] xfs: current patch queue for 3.11

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH 00/27] xfs: current patch queue for 3.11
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 13 Jun 2013 11:40:22 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51B87253.8060905@xxxxxxxxxx>
References: <1371032567-21772-1-git-send-email-david@xxxxxxxxxxxxx> <51B87253.8060905@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jun 12, 2013 at 09:06:27AM -0400, Brian Foster wrote:
> On 06/12/2013 06:22 AM, Dave Chinner wrote:
> > Hi folks,
> > 
> > This is an update of my current patch queue for the 3.11 release
> > cycle. This series starts on top of the patch series I posted for
> > 3.10-rc6, and builds upon the series previously posted last week:
> > 
> > http://oss.sgi.com/pipermail/xfs/2013-June/027040.html
> > 
> 
> Just a heads up, I applied this to tot and hit a few minor build errors:
> 
> fs/xfs/xfs_dir2_readdir.c:40:1: error: static declaration of
> âxfs_dir2_sf_getdentsâ follows non-static declaration
> In file included from fs/xfs/xfs_dir2_readdir.c:34:0:
> fs/xfs/xfs_dir2_priv.h:127:12: note: previous declaration of
> âxfs_dir2_sf_getdentsâ was here
> fs/xfs/xfs_dir2_readdir.c:143:1: error: static declaration of
> âxfs_dir2_block_getdentsâ follows non-static declaration
> In file included from fs/xfs/xfs_dir2_readdir.c:34:0:
> fs/xfs/xfs_dir2_priv.h:32:12: note: previous declaration of
> âxfs_dir2_block_getdentsâ was here
> fs/xfs/xfs_dir2_readdir.c:455:1: error: static declaration of
> âxfs_dir2_leaf_getdentsâ follows non-static declaration
> In file included from fs/xfs/xfs_dir2_readdir.c:34:0:
> fs/xfs/xfs_dir2_priv.h:68:12: note: previous declaration of
> âxfs_dir2_leaf_getdentsâ was here
> 
> In each case, it looks like patch 14/27 (xfs: move getdents code into
> it's own file) moved the associated function and added a STATIC to the
> function definition. Given the title of the patch, I removed the
> STATIC's and moved on to this one:
> 
> fs/xfs/xfs_dir2_data.c:39:1: error: static declaration of
> âxfs_dir2_data_freefindâ follows non-static declaration
> In file included from fs/xfs/xfs_dir2_data.c:31:0:
> fs/xfs/xfs_dir2.h:125:35: note: previous declaration of
> âxfs_dir2_data_freefindâ was here
> 
> That one appears to be due to 15/27 (xfs: reshuffle dir2 definitions
> around for userspace) adding a header declaration to a static function.
> 
> diff appended for reference.

Oh, I haven't build a non-debug version of the kernel. My bad. I'll
fix it up.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>