xfs
[Top] [All Lists]

Re: [PATCH 00/48] xfsprogs: CRC support

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 00/48] xfsprogs: CRC support
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 11 Jun 2013 13:38:12 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130610235641.GH29376@dastard>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <20130607061139.GM29338@dastard> <20130607210447.GP20932@xxxxxxx> <20130610235641.GH29376@dastard>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey Dave,

On Tue, Jun 11, 2013 at 09:56:41AM +1000, Dave Chinner wrote:
> On Fri, Jun 07, 2013 at 04:04:47PM -0500, Ben Myers wrote:
> > Hey,
> > 
> > On Fri, Jun 07, 2013 at 04:11:39PM +1000, Dave Chinner wrote:
> > > On Fri, Jun 07, 2013 at 10:25:23AM +1000, Dave Chinner wrote:
> > > > Hi folks,
> > > > 
> > > > This is the latest update of the series of patches tht introduces
> > > > CRC support into xfsprogs. Of note, for CRC enabled filesystems;
> > > > 
> > > >         - write support for xfs-db is disabled
> > > >         - obfuscation for metadump is disabled
> > > >         - xfs_check does nothing ("always succeed") so that xfstests
> > > >           can run without needing this
> > > >         - all structures shoul dbe supported for printing in xfs_db
> > > >         - xfs_repair should be able to fully validate the structure
> > > >           of a CRC enabled filesystem.
> > > >         - xfs_repair still ignores CRC validation errors when
> > > >           reading metadata
> > > >         - mkfs.xfs enforces limitations on the format of CRC enabled
> > > >           filesystems (inode size, attr format, projid32bit, etc).
> > > >         - whenever a v5 superblock is parsed on read by any utility,
> > > >           it outputs a wanring about it being an experimental
> > > >           format.
> > > > 
> > > > Bug reports, patches, comments, reviews, etc all welcome.
> > > 
> > > I've just realised that I haven't ported any of the recent kernel
> > > fixes across to this patch set, so there will be another few patches
> > > needed for those as well...
> > 
> > These two series are applied to the crc-dev branch at
> > git://oss.sgi.com/xfs/cmds/xfsprogs.git 
> 
> Hi Ben,
> 
> Thanks for doing this. This patch, however:
> 
> [PATCH 10/12] xfs: fully initialise temp leaf in xfs_attr3_leaf_compact
> 
> is missing from the branch. Can you commit it, please?

Ah.  Sorry about that.  It's applied now.

Regards,
        Ben

<Prev in Thread] Current Thread [Next in Thread>