xfs
[Top] [All Lists]

[PATCH 05/12] xfs: remote attribute allocation may be contiguous

To: xfs@xxxxxxxxxxx
Subject: [PATCH 05/12] xfs: remote attribute allocation may be contiguous
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 7 Jun 2013 22:24:54 +1000
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370607901-11538-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <1370607901-11538-1-git-send-email-david@xxxxxxxxxxxxx>
From: Dave Chinner <dchinner@xxxxxxxxxx>

When CRCs are enabled, there may be multiple allocations made if the
headers cause a length overflow. This, however, does not mean that
the number of headers required increases, as the second and
subsequent extents may be contiguous with the previous extent. Hence
when we map the extents to write the attribute data, we may end up
with less extents than allocations made. Hence the assertion that we
consume th enumber of headers we calculated in the allocation loop
is incorrect and needs to be removed.

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
---
 libxfs/xfs_attr_remote.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/libxfs/xfs_attr_remote.c b/libxfs/xfs_attr_remote.c
index f0ca926..09a168b 100644
--- a/libxfs/xfs_attr_remote.c
+++ b/libxfs/xfs_attr_remote.c
@@ -336,6 +336,11 @@ xfs_attr_rmtval_set(
                 * into requiring more blocks. e.g. for 512 byte blocks, we'll
                 * spill for another block every 9 headers we require in this
                 * loop.
+                *
+                * Note that this can result in contiguous allocation of blocks,
+                * so we don't use all the space we allocate for headers as we
+                * have one less header for each contiguous allocation that
+                * occurs in the map/write loop below.
                 */
                if (crcs && blkcnt == 0) {
                        int total_len;
@@ -416,7 +421,6 @@ xfs_attr_rmtval_set(
                lblkno += map.br_blockcount;
        }
        ASSERT(valuelen == 0);
-       ASSERT(hdrcnt == 0);
        return 0;
 }
 
-- 
1.7.10.4

<Prev in Thread] Current Thread [Next in Thread>