xfs
[Top] [All Lists]

[PATCH 26/48] xfsprogs: disable xfs_check for CRC enabled filesystems

To: xfs@xxxxxxxxxxx
Subject: [PATCH 26/48] xfsprogs: disable xfs_check for CRC enabled filesystems
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 7 Jun 2013 10:25:49 +1000
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx>
From: Dave Chinner <dchinner@xxxxxxxxxx>

Until xfs_db has full metadata CRC support, xfs_check will not be
able to fully verify filesystems in this format. Don't even
bother trying right now, and to make it simple to test full xfsprogs
installs with xfstests, just silently succeed.

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
---
 db/check.c |   14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/db/check.c b/db/check.c
index 5b7498f..dadfa97 100644
--- a/db/check.c
+++ b/db/check.c
@@ -788,6 +788,20 @@ blockget_f(
                dbprintf(_("already have block usage information\n"));
                return 0;
        }
+
+       /*
+        * XXX: check does not support CRC enabled filesystems. Return
+        * immediately, silently, with success but  without doing anything here
+        * initially so that xfstests can run without modification on metadata
+        * enabled filesystems.
+        *
+        * XXX: ultimately we need to dump an error message here that xfstests
+        * filters out, or we need to actually do the work to make check support
+        * crc enabled filesystems.
+        */
+       if (xfs_sb_version_hascrc(&mp->m_sb))
+               return 0;
+
        if (!init(argc, argv)) {
                if (serious_error)
                        exitcode = 3;
-- 
1.7.10.4

<Prev in Thread] Current Thread [Next in Thread>