xfs
[Top] [All Lists]

Re: [PATCH 0/1] xfs: xfs_inactive fails to cleanup symlinks with attribu

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH 0/1] xfs: xfs_inactive fails to cleanup symlinks with attributes
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 7 Jun 2013 07:51:49 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51B0FF1D.60402@xxxxxxx>
References: <20130606161032.753011157@xxxxxxx> <51B0E03B.3010303@xxxxxxx> <20130606211307.GB29338@dastard> <51B0FF1D.60402@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jun 06, 2013 at 04:29:01PM -0500, Mark Tinguely wrote:
> On 06/06/13 16:13, Dave Chinner wrote:
> >On Thu, Jun 06, 2013 at 02:17:15PM -0500, Mark Tinguely wrote:
> >>On 06/06/13 11:10, Mark Tinguely wrote:
> >>>Found this bug testing extended attributes.
> >>>
> >>># make a big symbolic link that is in the inode core and mostly fills it.
> >>># CRC enabled filesystem will use a 68 byte smaller link in the test.
> >>>
> >>>ln -s 
> >>>1234567890/1234567890/1234567890/1234567890/1234567890/1234567890/1234567890/1234567890/1234567890/1234567890/1234567890/0123456/a
> >>> a
> >>>
> >>># the extended attribute will bump the symbolic link to a remote extent
> >>># I think only one of these attribute is needed, but they are so fun...
> >>>attr  -Rs 1234567890ad a<   /dev/null
> >>>attr  -Rs 1234567890ae a<   /dev/null
> >>>attr  -Rs 1234567890af a<   /dev/null
> >>>
> >>
> >>oops. the following steps are also needed - I took them out because I
> >>thought they were unecessary:
> >>
> >># remove the attributes:
> >>attr  -Rr 1234567890ad a
> >>attr  -Rr 1234567890ae a
> >>attr  -Rr 1234567890af a
> >>
> >>now we will assert
> >
> >I cannot reproduce this on a current TOT kernel with or without
> >CRCs:
> >
> ># mkfs.xfs -f /dev/vdb
> >meta-data=/dev/vdb               isize=256    agcount=4, agsize=720896 blks
.....
> 
> Yes, these instructions are for a *256* byte inode with top of tree code.

Yup, that's what I was testing with. It's right there in the mkfs
output I posted. Hence I want your exact test script that reproduces
it, in case there's still something missing from what you've sent as
the test case....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>