| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/4] xfs: inode unlinked list needs to recalculate the inode CRC |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Wed, 05 Jun 2013 09:43:32 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1370398150-12084-3-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1370398150-12084-1-git-send-email-david@xxxxxxxxxxxxx> <1370398150-12084-3-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 |
On 06/04/13 21:09, Dave Chinner wrote: From: Dave Chinner<dchinner@xxxxxxxxxx> The inode unlinked list manipulations operate directly on the inode buffer, and so bypass the inode CRC calculation mechanisms. Hence an inode on the unlinked list has an invalid CRC. Fix this by recalculating the CRC whenever we modify an unlinked list pointer in an inode, ncluding during log recovery. This is trivial to do and results in unlinked list operations always leaving a consistent inode in the buffer. Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx> --- Looks good. Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 4/4] xfs: increase number of ACL entries for V5 superblocks, Mark Tinguely |
|---|---|
| Next by Date: | [XFS updates] XFS development tree branch, master, updated. v3.10-rc1-29-g5c87d4b, xfs |
| Previous by Thread: | [PATCH 2/4] xfs: inode unlinked list needs to recalculate the inode CRC, Dave Chinner |
| Next by Thread: | [PATCH 3/4] xfs: disable noattr2/attr2 mount options for CRC enabled filesystems, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |