xfs
[Top] [All Lists]

Re: [PATCH 4/6] xfs: fix remote attribute invalidation for a leaf

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/6] xfs: fix remote attribute invalidation for a leaf
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Mon, 03 Jun 2013 14:59:23 -0400
Cc: xfs@xxxxxxxxxxx, bpm@xxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370237332-24757-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1370237332-24757-1-git-send-email-david@xxxxxxxxxxxxx> <1370237332-24757-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6
On 06/03/2013 01:28 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When invalidating an attribute leaf block block, there might be
> remote attributes that it points to. With the recent rework of the
> remote attribute format, we have to make sure we calculate the
> length of the attribute correctly. We aren't doing that in
> xfs_attr3_leaf_inactive(), so fix it.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

> ---
>  fs/xfs/xfs_attr_leaf.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_attr_leaf.c b/fs/xfs/xfs_attr_leaf.c
> index d788302..31d3cd1 100644
> --- a/fs/xfs/xfs_attr_leaf.c
> +++ b/fs/xfs/xfs_attr_leaf.c
> @@ -3258,7 +3258,7 @@ xfs_attr3_leaf_inactive(
>                       name_rmt = xfs_attr3_leaf_name_remote(leaf, i);
>                       if (name_rmt->valueblk) {
>                               lp->valueblk = be32_to_cpu(name_rmt->valueblk);
> -                             lp->valuelen = XFS_B_TO_FSB(dp->i_mount,
> +                             lp->valuelen = xfs_attr3_rmt_blocks(dp->i_mount,
>                                                   
> be32_to_cpu(name_rmt->valuelen));
>                               lp++;
>                       }
> 

<Prev in Thread] Current Thread [Next in Thread>