xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix seek_sanity_test for fs w/o fallocate

To: Rich Johnston <rjohnston@xxxxxxx>
Subject: Re: [PATCH] xfstests: fix seek_sanity_test for fs w/o fallocate
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 31 May 2013 23:51:32 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, ext4 development <linux-ext4@xxxxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51A8F3CE.4030801@xxxxxxx>
References: <51A8C59B.3030308@xxxxxxxxxx> <20130531172456.GB6915@xxxxxxxxx> <51A8DACB.2030806@xxxxxxxxxx> <51A8F3CE.4030801@xxxxxxx>
On May 31, 2013, at 2:02 PM, Rich Johnston <rjohnston@xxxxxxx> wrote:

> On 05/31/2013 12:15 PM, Eric Sandeen wrote:
>> On 5/31/13 12:24 PM, Zheng Liu wrote:
>>> On Fri, May 31, 2013 at 10:45:31AM -0500, Eric Sandeen wrote:
>>>> currently the seek_sanity_test (generic/285) fails on ext3
>>>> or ext2 due to fallocate() failures.  Just ignore that test
>>>> if the fs doesn't support fallocate.
>>> 
>>> Hi Eric,
>>> 
>>> I remember that my patch had been applied [1].  But stranger I couldn't
>>> find it in xfstests tree.  However, I think that your patch is better.
>>> 
>>> 1. http://oss.sgi.com/archives/xfs/2013-05/msg00534.html
>> 
>> Oh, right, I had forgotten about that.  Rich, any idea?
> 
> No other than it was a Friday.  My apologies Zheng.
> Zheng as your's should have been committed, what do you want me to do?
> 
Actually let's merge mine since it allows testing on ext2/3.  The other just 
disables those filesystems...

-Eric

> --Rich
> 
>> 
>> I don't care which patch goes in....
>> 
>> -Eric
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>