xfs
[Top] [All Lists]

Re: XFStest suite problem

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: XFStest suite problem
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 31 May 2013 08:43:58 +1000
Cc: alexander.tsvetkov@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51A75745.7090805@xxxxxxxxxxx>
References: <51A708B2.2080701@xxxxxxxxxx> <51A75745.7090805@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, May 30, 2013 at 08:42:29AM -0500, Eric Sandeen wrote:
> On 5/30/13 3:07 AM, alexander.tsvetkov@xxxxxxxxxx wrote:
> > I think the following code of "check" script incorrectly builds this 
> > exclude list:
> > 
> > "-X) xfile=$2; shift ;
> > for d in $SRC_GROUPS $FSTYP; do
> > [ -f $SRC_DIR/$d/$xfile ] || continue
> > for f in `cat $SRC_DIR/$d/$xfile`; do
> > echo $d/$f >> $tmp.xlist
> 
> Well, it is perhaps unexpected, but:
> 
>     -X file           exclude individual tests
> 
> I think it's designed to actually exclude tests contained in that
> file, not test numbers.  It's not very obvious.  :(

Right, it's a file full of test numbers to expunged. Two things can
be done here:

        1. improve the description
        2. change the `cat $file` to `egrep ^$SUPPORTED_TESTS $file`
           so that it requires files in the same format as group
           files.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>