xfs
[Top] [All Lists]

Re: [PATCH V2] xfstests: Fix test wildcard expansion.

To: xfstests <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH V2] xfstests: Fix test wildcard expansion.
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Thu, 30 May 2013 17:32:48 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51A7CC6B.3030607@xxxxxxx>
References: <51A7CC6B.3030607@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0

Before commit 38d58591 "xfstests: fix typo in check",
check xfs/[0-9]?? would execute all tests/xfs/[0-9]?? because:

Change to use egrep to fix the parsing.

Signed-off-by: Rich Johnston <rjohnston@xxxxxxx>
---
V1-V2
Use egrep instead of my bulky method

diff --git a/check b/check
index 8d32486..ff8fbcf 100755
--- a/check
+++ b/check
@@ -242,7 +242,7 @@ if $have_test_arg; then
                        test_name=`basename $1`
                        group_file=$SRC_DIR/$test_dir/group

-                       if grep "^$test_name" $group_file >/dev/null ; then
+                       if egrep "^$test_name" $group_file >/dev/null ; then
                                # in group file ... OK
                                echo $SRC_DIR/$1 >>$tmp.list
                        else


<Prev in Thread] Current Thread [Next in Thread>