xfs
[Top] [All Lists]

Re: [PATCH 2/3] 285: Fix file syncing

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH 2/3] 285: Fix file syncing
From: Jan Kara <jack@xxxxxxx>
Date: Thu, 30 May 2013 21:57:23 +0200
Cc: Jan Kara <jack@xxxxxxx>, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51A75872.4080909@xxxxxxxxxx>
References: <1369917939-22660-1-git-send-email-jack@xxxxxxx> <1369917939-22660-2-git-send-email-jack@xxxxxxx> <51A75872.4080909@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu 30-05-13 08:47:30, Eric Sandeen wrote:
> On 5/30/13 7:45 AM, Jan Kara wrote:
> > The intention of tests 08 and 09 in test generic/285 is to sync the
> > whole file before checking for data and holes. However the helper is
> > called with nbytes argument set to 0 which results in not syncing
> > anything. Set nbytes properly.
> 
> Hm, are you sure? (Is the man page wrong, or is the sync_file_range
> implementation wrong?)
> 
> DESCRIPTION
>        sync_file_range()  permits  fine  control when synchronizing the
>        open file referred to by the file descriptor fd with disk.
> 
>        offset is the starting byte of the file  range  to  be  synchro-
>        nized.   nbytes specifies the length of the range to be synchro-
>        nized, in bytes; if nbytes is zero, then all bytes  from  offset
>        through to the end of file are synchronized.
  My fault that I didn't read the manpage carefully enough. Scratch this
patch.

                                                                Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR

<Prev in Thread] Current Thread [Next in Thread>