[Top] [All Lists]

[XFS updates] XFS development tree branch, master, updated. v3.10-rc1-23

To: xfs@xxxxxxxxxxx
Subject: [XFS updates] XFS development tree branch, master, updated. v3.10-rc1-23-g5ae6e6a
From: xfs@xxxxxxxxxxx
Date: Thu, 30 May 2013 14:40:02 -0500 (CDT)
Delivered-to: xfs@xxxxxxxxxxx
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".

The branch, master has been updated
  5ae6e6a xfs: fix dir3 freespace block corruption
      from  56c19e89b38618390addfc743d822f99519055c6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5ae6e6a401957698f2bd8c9f4a86d86d02199fea
Author: Dave Chinner <dchinner@xxxxxxxxxx>
Date:   Tue May 28 18:37:17 2013 +1000

    xfs: fix dir3 freespace block corruption
    When the directory freespace index grows to a second block (2017
    4k data blocks in the directory), the initialisation of the second
    new block header goes wrong. The write verifier fires a corruption
    error indicating that the block number in the header is zero. This
    was being tripped by xfs/110.
    The problem is that the initialisation of the new block is done just
    fine in xfs_dir3_free_get_buf(), but the caller then users a dirv2
    structure to zero on-disk header fields that xfs_dir3_free_get_buf()
    has already zeroed. These lined up with the block number in the dir
    v3 header format.
    While looking at this, I noticed that the struct xfs_dir3_free_hdr()
    had 4 bytes of padding in it that wasn't defined as padding or being
    zeroed by the initialisation. Add a pad field declaration and fully
    zero the on disk and in-core headers in xfs_dir3_free_get_buf() so
    that this is never an issue in the future. Note that this doesn't
    change the on-disk layout, just makes the 32 bits of padding in the
    layout explicit.
    Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
    Reviewed-by: Ben Myers <bpm@xxxxxxx>
    Signed-off-by: Ben Myers <bpm@xxxxxxx>


Summary of changes:
 fs/xfs/xfs_dir2_format.h |  1 +
 fs/xfs/xfs_dir2_node.c   | 13 ++++++-------
 2 files changed, 7 insertions(+), 7 deletions(-)

XFS development tree

<Prev in Thread] Current Thread [Next in Thread>
  • [XFS updates] XFS development tree branch, master, updated. v3.10-rc1-23-g5ae6e6a, xfs <=