xfs
[Top] [All Lists]

Re: [PATCH 5/9] xfs: fix split buffer vector log recovery support

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH 5/9] xfs: fix split buffer vector log recovery support
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 30 May 2013 12:49:47 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51A65550.50508@xxxxxxx>
References: <1369636707-15150-1-git-send-email-david@xxxxxxxxxxxxx> <1369636707-15150-6-git-send-email-david@xxxxxxxxxxxxx> <51A65550.50508@xxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, May 29, 2013 at 02:21:52PM -0500, Mark Tinguely wrote:
> On 05/27/13 01:38, Dave Chinner wrote:
> >From: Dave Chinner<dchinner@xxxxxxxxxx>
> >
> >A long time ago in a galaxy far away....
> >
> >.. the was a commit made to fix some ilinux specific "fragmented
> >buffer" log recovery problem:
> >
> >http://oss.sgi.com/cgi-bin/gitweb.cgi?p=archive/xfs-import.git;a=commitdiff;h=b29c0bece51da72fb3ff3b61391a391ea54e1603
> >
> >That problem occurred when a contiguous dirty region of a buffer was
> >split across across two pages of an unmapped buffer. It's been a
> >long time since that has been done in XFS, and the changes to log
> >the entire inode buffers for CRC enabled filesystems has
> >re-introduced that corner case.
> >
> >And, of course, it turns out that the above commit didn't actually
> >fix anything - it just ensured that log recovery is guaranteed to
> >fail when this situation occurs. And now for the gory details.
> >
> ...
> 
> Thanks for the great walk through of the problem.
> 
> Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

Applied.

<Prev in Thread] Current Thread [Next in Thread>