xfs
[Top] [All Lists]

Re: [PATCH 1/9] xfs: don't emit v5 superblock warnings on write

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH 1/9] xfs: don't emit v5 superblock warnings on write
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 30 May 2013 12:49:15 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51A62F2F.6040807@xxxxxxxxxx>
References: <1369636707-15150-1-git-send-email-david@xxxxxxxxxxxxx> <1369636707-15150-2-git-send-email-david@xxxxxxxxxxxxx> <51A62F2F.6040807@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, May 29, 2013 at 12:39:11PM -0400, Brian Foster wrote:
> On 05/27/2013 02:38 AM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > We write the superblock every 30s or so which results in the
> > verifier being called. Right now that results in this output
> > every 30s:
> > 
> > XFS (vda): Version 5 superblock detected. This kernel has EXPERIMENTAL 
> > support enabled!
> > Use of these features in this kernel is at your own risk!
> > 
> > And spamming the logs.
> > 
> > We don't need to check for whether we support v5 superblocks or
> > whether there are feature bits we don't support set as these are
> > only relevant when we first mount the filesytem. i.e. on superblock
> > read. Hence for the write verification we can just skip all the
> > checks (and hence verbose output) altogether.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> > ---
> 
> Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

Applied.

<Prev in Thread] Current Thread [Next in Thread>