xfs
[Top] [All Lists]

Re: [PATCH 7/9] xfs: kill suid/sgid through the truncate path.

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH 7/9] xfs: kill suid/sgid through the truncate path.
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 30 May 2013 10:52:08 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51A75F7A.6040302@xxxxxxxxxx>
References: <1369636707-15150-1-git-send-email-david@xxxxxxxxxxxxx> <1369636707-15150-8-git-send-email-david@xxxxxxxxxxxxx> <51A75F7A.6040302@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey Brian,

On Thu, May 30, 2013 at 10:17:30AM -0400, Brian Foster wrote:
> On 05/27/2013 02:38 AM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > XFS has failed to kill suid/sgid bits correctly when truncating
> > files of non-zero size since commit c4ed4243 ("xfs: split
> > xfs_setattr") introduced in the 3.1 kernel. Fix it.
> > 
> 
> The code makes sense and I can easily hit an assert when truncating
> (extending) a suid file on a debug kernel without this patch (and I see
> the suid dropped with the patch).

What commands did you use?  It seems like this is dealing with S_ISGID, correct?

Thanks,
        Ben

<Prev in Thread] Current Thread [Next in Thread>