[Top] [All Lists]

Re: XFStest suite problem

To: alexander.tsvetkov@xxxxxxxxxx
Subject: Re: XFStest suite problem
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 30 May 2013 08:42:29 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51A708B2.2080701@xxxxxxxxxx>
References: <51A708B2.2080701@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130509 Thunderbird/17.0.6
On 5/30/13 3:07 AM, alexander.tsvetkov@xxxxxxxxxx wrote:
> I think the following code of "check" script incorrectly builds this exclude 
> list:
> "-X) xfile=$2; shift ;
> for d in $SRC_GROUPS $FSTYP; do
> [ -f $SRC_DIR/$d/$xfile ] || continue
> for f in `cat $SRC_DIR/$d/$xfile`; do
> echo $d/$f >> $tmp.xlist

Well, it is perhaps unexpected, but:

    -X file             exclude individual tests

I think it's designed to actually exclude tests contained in that file, not 
test numbers.  It's not very obvious.  :(

But from the commit log:

commit 0b1e8abd4a6dbce54bcc5d0467e58966e41e7eb8
Author: Dave Chinner <dchinner@xxxxxxxxxx>
Date:   Fri Mar 15 12:28:05 2013 +0000

    xfstests: Reintroduce configurable test expunging.
    It is definitely handy to be able to disabdle certain tests (e.g. tests 
that are
    known to hang or crash the test machine on certain kernels), so 
    the capability of avoiding certain tests just by placing them in a file is
    Introduce a command line option to specify the expunged file name. The file 
    exist in each tests/* sub-directory so that only the testname is required, 
    can be managed independently. The use of a command line parameter allows
    multiple expunge files to exist simultaneously in the one xfstests tree 
    simplifies management of a source repository used for multiple versions of a
    Typical usage:
    $ cat tests/generic/3.0-stable-avoid
    $ sudo ./check -X 3.0-stable-avoid generic/280
    FSTYP         -- xfs (debug)
    PLATFORM      -- Linux/x86_64 test-1 3.0.39-dgc+
    MKFS_OPTIONS  -- -f -bsize=4096 /dev/vdb
    MOUNT_OPTIONS -- /dev/vdb /mnt/scratch
    generic/280     [expunged]
    Passed all 0 tests

<Prev in Thread] Current Thread [Next in Thread>