xfs
[Top] [All Lists]

XFStest suite problem

To: xfs@xxxxxxxxxxx
Subject: XFStest suite problem
From: alexander.tsvetkov@xxxxxxxxxx
Date: Thu, 30 May 2013 12:07:14 +0400
Delivered-to: xfs@xxxxxxxxxxx
Organization: Oracle Corporation
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Oracle/3.1.11-2.0.1.el6_1 Lightning/1.0b2 OracleBeehiveExtension/1.0.0.2-OracleInternal ObetStats/CATLAF_1360077495220-530802236 Thunderbird/3.1.11
Hello,

There is a problem found in XFS tests suite: attempt to run XFS tests with some tests excluded from run, for example, "./check -g auto -X 231" causes the unexpected exclusion of some other tests (for example generic/127 in this case). Looking into suite's created exclude list indicates that it was incorrectly built by including some garbage together with correct test numbers records, so /tmp/30535.xlist looks like:

"generic/#!
generic//bin/bash
generic/#
generic/FSQA
generic/Test
generic/No.
generic/231
generic/#
generic/#
generic/Run
generic/fsx
generic/with
generic/quotas
generic/enabled
generic/and
generic/verify
generic/accounted
generic/quotas
generic/in
generic/the
generic/end
generic/#
generic/#
generic/Derived
generic/from
generic/test
generic/127
generic/#-----------------------------------------------------------------------
generic/#
generic/Copyright
generic/(c)
generic/2006
generic/Silicon
generic/Graphics,
..."

I think the following code of "check" script incorrectly builds this exclude list:

"-X) xfile=$2; shift ;
for d in $SRC_GROUPS $FSTYP; do
[ -f $SRC_DIR/$d/$xfile ] || continue
for f in `cat $SRC_DIR/$d/$xfile`; do
echo $d/$f >> $tmp.xlist
done
done
;;"

Used XFStests suite version from 2013-05-22.

Thanks,
Alexander Tsvetkov

<Prev in Thread] Current Thread [Next in Thread>