xfs
[Top] [All Lists]

Re: [PATCH] xfstests: add missing colon in _filter_ln

To: Eryu Guan <eguan@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: add missing colon in _filter_ln
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 29 May 2013 11:21:16 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1369842106-9869-1-git-send-email-eguan@xxxxxxxxxx>
References: <1369842106-9869-1-git-send-email-eguan@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130509 Thunderbird/17.0.6
On 5/29/13 10:41 AM, Eryu Guan wrote:
> On distros with older coreutils(eg. RHEL5) generic/294 fails like
> 
>     -ln: creating symbolic link `SCRATCH_MNT/294.test/testlink': File exists
>     +ln: creating symbolic link `SCRATCH_MNT/294.test/testlink'File exists
> 
> _filter_ln ate the ": ". xfs/103 has similar issue. Add ": " back.

Ok, so older coreutils does i.e.:

ln: creating symbolic link `b' to `a': File exists

and newer:

ln: creating symbolic link `b': File exists

We want to convert the older output to the newer, by removing the " to `a'" 
part.

Seems like my sed script is the long way around that ;)

Still, looks like your fix does the right thing, thanks.

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

-Eric

> Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx>
> ---
>  common/filter | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/filter b/common/filter
> index bdd6427..dbb1674 100644
> --- a/common/filter
> +++ b/common/filter
> @@ -243,7 +243,7 @@ _filter_spaces()
>  # Account for different "ln" failure messages
>  _filter_ln()
>  {
> -     sed -e "s,\(creating symbolic link .*\) to .*: ,\1," \
> +     sed -e "s,\(creating symbolic link .*\) to .*: ,\1: ," \
>           -e "s,failed to create,creating,"
>  }
>  
> 

<Prev in Thread] Current Thread [Next in Thread>