xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix src/seek_sanity_test -t option

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix src/seek_sanity_test -t option
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Tue, 28 May 2013 10:57:22 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>, ext4 development <linux-ext4@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <519EF4AE.60702@xxxxxxxxxx>
References: <519EF4AE.60702@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5
On 05/24/2013 12:03 AM, Eric Sandeen wrote:
_require_seek_data_hole() does not work because
the -t (test) option of seek_sanity_test is broken,
because of an early check for (argc != 2):

# src/seek_sanity_test -t foo
Usage: src/seek_sanity_test base_file_path

So _require_seek_data_hole() doesn't see the
"Kernel does not support" string it's looking for,
and passes the check.

So rather than _notrun-ing the test, it proceeds to
fail with noisy errors.

Fix that, make a common usage() function, and check for
too many args as well.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Thanks, this has been committed:

commit bd13bf9e2a87a40d3aab2644967029b854ed2d11
Author: Eric Sandeen <sandeen@xxxxxxxxxx>
Date:   Tue May 28 10:37:39 2013 -0500

    xfstests: fix src/seek_sanity_test -t option

--Rich

<Prev in Thread] Current Thread [Next in Thread>