xfs
[Top] [All Lists]

Re: Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstes

To: Jens Axboe <axboe@xxxxxxxxx>
Subject: Re: Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78]
From: Phillip Susi <psusi@xxxxxxxxxx>
Date: Tue, 28 May 2013 10:51:02 -0400
Cc: CAI Qian <caiqian@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <515DE2FE.1080201@xxxxxxxxxx>
References: <1462091996.435156.1364882416199.JavaMail.root@xxxxxxxxxx> <247719576.438259.1364882929749.JavaMail.root@xxxxxxxxxx> <20130402070537.GP6369@dastard> <20130402071937.GC3670@xxxxxxxxx> <20130402073035.GD3670@xxxxxxxxx> <14055702.547701.1364891947331.JavaMail.root@xxxxxxxxxx> <20130402090047.GF3670@xxxxxxxxx> <985125161.581860.1364895066584.JavaMail.root@xxxxxxxxxx> <20130402094834.GA4667@xxxxxxxxx> <20130403114142.GP4667@xxxxxxxxx> <515C4D9D.10103@xxxxxxxxxx> <515DE2FE.1080201@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130509 Thunderbird/17.0.6
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Jens, did this get lost in the shuffle, or just miss the window for
3.10 and will go in 3.11?

On 4/4/2013 4:30 PM, Phillip Susi wrote:
>> I have not tested it yet, but I am pretty sure it won't work.
>> It looks like the patch changes the BLKRRPART path to go ahead
>> and remove existing partitions when GENHD_FL_NO_PARTSCAN is set.
>> loop doesn't issue the BLKRRPART ioctl when !LO_FLAGS_PARTSCAN so
>> this won't help. I think loop needs to set GENHD_FL_NO_PARTSCAN
>> and then issue the ioctl regardless of the LO_FLAGS_PARTSCAN flag
>> to get the partitions to be removed.  I will try to test
>> tonight.
> 
> After testing, my initial thoughts appeared to have been correct.
> I had to modify the patch as follows.  To test, simply do:
> 
> truncate -s 10m img losetup /dev/loop0 img parted /dev/loop0 
> mklabel msdos mkpart primary ext2 1m 2m quit ls /dev/loop0*
> 
> Note the /dev/loop0p1 node.  Run losetup -d /dev/loop0 and see if
> it is still there.
> 
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJRpMRWAAoJEJrBOlT6nu75yUYH/1PSNmTOBYgvEqQclWPBTd8n
Fm95yILcIlJWdUr3gUvQmjBax1NzKnG3NZ2U4hucpCcJH4FkHSTTFl5uZ3wU1B/Q
nvuQoSqYXVP+V9PVSTsUsxOI4Mvw5YP5sFwSdwRKpkCldXOuHrRZsuccFtkQducU
AIij42jvI1un+/qc6NLW+/S+rcLGUj21boPmX3g80km1De9QMrYrbGAAEbFO3rrq
fzsvGuVvOroGppLGpze4iMDn060Lxrw6//KDGtiUBIeD8kZCFGkBh1KupHqLLzXm
gmfdlHIqAR5uWB29m9TOlRbHPzdeQutwt8zL2LOYlCft5OiBIOW8dT8EFkl2Buw=
=7BGq
-----END PGP SIGNATURE-----

<Prev in Thread] Current Thread [Next in Thread>
  • Re: Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78], Phillip Susi <=