[Top] [All Lists]

Re: xfsprogs: is it one issue?

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: xfsprogs: is it one issue?
From: Zhi Yong Wu <zwu.kernel@xxxxxxxxx>
Date: Mon, 27 May 2013 09:16:43 +0800
Cc: "Michael L. Semon" <mlsemon35@xxxxxxxxx>, xfstests <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=chA8khOYkotg+fd2Oe5OBrmq0rvAOa0ZU1I1lDg7ebg=; b=kPylab/bKEN84Y+vSMK4q48MCyjgD9xF9iCnjp9p0wn48o90DhdpW8dJ9gjLlQvwDd LnHEv6OFZUS+7i9KqMKhq28mf4iAkNsNikjCapDtsL6vNayfy5vG9DDr7NxYX3/fBjPf JLx1LcSvaxGXRXzJE4N0v3ODIYRjopokPnNYAZ3PpXJ9FTozQs7eynfDi/Dm8iCNau+t t/ouxMrLvk167eRptn9RTVHOqbwPNaZSdQBauB9mY7hs1uzIN1J8DYhKck/1Ef3HTLo/ S9WCYi4ZdhhApTxQ3HDpJPJMbPmJB3SJnERlLIrA8DsgSV7CCMayZETg4kgeXbLD3XhO pIjg==
In-reply-to: <20130526231122.GO24543@dastard>
References: <CAEH94LjnVn-uD6cfwOcChC4wq1PppcD8BN30F93SD=YjdTbbuw@xxxxxxxxxxxxxx> <51A1144A.4020600@xxxxxxxxx> <CAEH94LgWQcjSMenoT3a81pLWbw2pEYWpKFyGwoxAvDX2FTwbXA@xxxxxxxxxxxxxx> <CAEH94Lj4_8PBbhdD2f-ZFG=NxgS2uBkGUfaQvct71H4X7giPZA@xxxxxxxxxxxxxx> <20130526231122.GO24543@dastard>
ah, another way by not building-in loggen, thanks.

On Mon, May 27, 2013 at 7:11 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
On Sun, May 26, 2013 at 07:11:03AM +0800, Zhi Yong Wu wrote:
> I remove the lines related to h_chksum, then it can work well, so i
> guess that i should send out one patch to fix it.

While it will make the code in loggen work the same (it just writes
0 to the field but the buffer is already zeroed) as it does now,
it doesn't necessarily mean it works correctly. The current kernels
validate the CRC and throw warnings if the CRC isn't correct, and
CRC enabled kernels will simply refuse to mount.

As it is, my test systems don't build loggen because
HAVE_XLOG_ASSIGN_LSN isn't set by configure. It only gets set if
there's an xfs/libxfs.h header file found in an include path. My
guess is that you've run 'make install-qa' in the xfsprogs package
at some time in the past, and that's why loggen is trying to be

So Michael's quick hack to remove it just to make it compile at this
point is probably appropriate...


Dave Chinner

Zhi Yong Wu
<Prev in Thread] Current Thread [Next in Thread>