xfs
[Top] [All Lists]

Re: [PATCH] xfstests: cleanup the codes related to h_chksum

To: zwu.kernel@xxxxxxxxx
Subject: Re: [PATCH] xfstests: cleanup the codes related to h_chksum
From: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
Date: Sun, 26 May 2013 17:37:41 -0400
Cc: xfs@xxxxxxxxxxx, Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=ejfSFy+V916NXJ8jhAqaAmNKrzmt4mC12f0uCL/uaS8=; b=UdpjpHWlkipgCbdX5LHbahYDCS0jSmJmWJBCQCjCbulPBrDhCP6PGvPoRzhBMkE4YB 8tgVRT9XUJpi0dnjqfED8NjnO7fteeiX+Gm8X/cYCln9x0TFpWhmP+1F/HsiOSDCS3ZG YE7E2J7kg1yZAtAnUq/fvKv11mtXyfUrpRdtT0V3bdj8jt9ClOzcq/Nx0WsEqaGVezZd 6/Ay2J5I2Z8PeNC1TkZRFYX9Arcq/Mzf489DLozqJt7UulQpbAC9T6Wfd4Np183CCF8s /AeQH06K60eGbVMIEW6A/kKTIvvvAqNwocJtdNpz4zKfYB6A7YdVqcwRim8lCJ/YJ6WE GysA==
In-reply-to: <1369523732-10649-1-git-send-email-zwu.kernel@xxxxxxxxx>
References: <1369523732-10649-1-git-send-email-zwu.kernel@xxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130509 Thunderbird/17.0.6
On 05/25/2013 07:15 PM, zwu.kernel@xxxxxxxxx wrote:
> From: Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>
> 
>   Since h_chksum field has gone away, we should cleanup the related codes
> 
>     [CC]    loggen
> loggen.c: In function 'loggen_unmount':
> loggen.c:137:9: error: 'xlog_rec_header_t' has no member named 'h_chksum'
> loggen.c: In function 'loggen_empty':
> loggen.c:205:9: error: 'xlog_rec_header_t' has no member named 'h_chksum'
> 
> Signed-off-by: Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>
> ---
>  src/loggen.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/src/loggen.c b/src/loggen.c
> index 4b55667..522c917 100644
> --- a/src/loggen.c
> +++ b/src/loggen.c
> @@ -134,7 +134,6 @@ loggen_unmount(int count)
>      head->h_cycle = cpu_to_be32(param_cycle);
>      head->h_version = cpu_to_be32(1);
>      head->h_len = cpu_to_be32(20);
> -    head->h_chksum = cpu_to_be32(0);
>      head->h_prev_block = cpu_to_be32(-1);
>      head->h_num_logops = cpu_to_be32(1);
>      head->h_cycle_data[0] = cpu_to_be32(0xb0c0d0d0);
> @@ -202,7 +201,6 @@ loggen_empty(int count)
>                                                      
> sizeof(xfs_trans_header_t)+
>                                                      
> sizeof(xfs_buf_log_format_t)+
>                                                      sizeof(int));
> -    head->h_chksum         = cpu_to_be32(0);
>      head->h_prev_block     = cpu_to_be32(-1);
>      head->h_num_logops     = cpu_to_be32(5);
>      head->h_cycle_data[0]  = cpu_to_be32(0xb0c0d0d0);
> 

I've been taking a wild guess and changing "h_chksum" to "h_crc", just 
as a pure sysadmin hack to keep going.  Is there more than one correct 
answer on this issue?

Michael

<Prev in Thread] Current Thread [Next in Thread>