xfs
[Top] [All Lists]

Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument'

To: Rich Johnston <rjohnston@xxxxxxx>
Subject: Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument'
From: Zhi Yong Wu <zwu.kernel@xxxxxxxxx>
Date: Sun, 26 May 2013 17:35:45 +0800
Cc: Wang Sheng-Hui <shhuiw@xxxxxxxxx>, list.btrfs@xxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, xfstests <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=mFhV4eO/kBcDD+j/z5UG4Rsj0ATaF+V26hp5G+BWe7I=; b=paOrPeZ8k0d+HdDsVMIjdphjmOw/smU4jJyef7itFLSWqMzvzyzqOEWXg8nmiR7Z99 z43OXaO+XW28vKzsYg2V5/tVkusZoJIGzrPTkN8wnyRpe4/w23Liz6IZKNUBapJA6Ml7 OWG2T1wVJq/RdknREUi4/GqZOhgsZ7vS7T8P3LyauudNDOKW2YBopFOc7TbJXB9ABLKe o08qOu1Vy8OQTCtX6Y0ORgod+gj06WpG0H6rPjZqjwNWUG2cfj7pOdZZLwh8k5zpq7n3 0nwE3K8NZSGoDYax8TqQ1CvjfUcOm1XAKi6VE+4GztSpKIkp5r544pL91S/DxM8LXrL3 TVrg==
In-reply-to: <51363CE6.1010807@xxxxxxx>
References: <512DB284.1090806@xxxxxxxxx> <51363CE6.1010807@xxxxxxx>
HI,

  This issue still exists when xfstests is run on debian although
xfstests has contained this patch.

root@debian-i386:/home/zwu/xfstests# git describe
linux-v3.8-122-gdc75401
root@debian-i386:/home/zwu/xfstests# uname -a
Linux debian-i386 3.10.0-rc2+ #3 SMP Sun May 26 14:04:13 CST 2013
x86_64 GNU/Linux
root@debian-i386:/home/zwu/xfstests#

 - output mismatch (see /home/zwu/xfstests/results/btrfs/276.out.bad)
    --- tests/btrfs/276.out    2013-05-25 15:09:01.000000000 +0000
    +++ /home/zwu/xfstests/results/btrfs/276.out.bad    2013-05-26
09:31:49.962876905 +0000
    @@ -1,3 +1,32393 @@
     QA output created by 276
     *** test backref walking
    +FIBMAP: Invalid argument
    +FIBMAP: Invalid argument
    +FIBMAP: Invalid argument
    +FIBMAP: Invalid argument
    +FIBMAP: Invalid argument
     ...
     (Run 'diff -u tests/btrfs/276.out
/home/zwu/xfstests/results/btrfs/276.out.bad' to see the entire diff)
[ 3877.215268] device fsid 8367602a-14fa-49eb-aff0-44da1faa3b45 devid
1 transid 239 /dev/vdb
[ 3877.218417] btrfs: disk space caching is enabled
Ran: btrfs/276
Failures: btrfs/276
Failed 1 of 1 tests

On Wed, Mar 6, 2013 at 2:43 AM, Rich Johnston <rjohnston@xxxxxxx> wrote:
> This patch has been committed.
>
> --Rich
>
> commit eba3a5206cd7f8df73d6e6dbf2bb0afca677fca8
> Author: Wang Sheng-Hui <shhuiw@xxxxxxxxx>
> Date:   Thu Feb 28 02:05:56 2013 +0000
>
>     xfstests 276: fix error 'FIBMAP: Invalid argument'
>
>
>     Commit 05dadc0 ("Btrfs: add fiemap's flag check") added validity
>     checks to the fiemap flags and hence invalid flags are now being
>     rejected. Test 276 passes an invalid fiemap flag to btrfs, and so
>     that test fails since this commit was added.
>
>     Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by -x option
>     of filefrag, and will fail with
>         'FIBMAP: Invalid argument'
>     for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with
>          'FIEMAP failed with unsupported flags 2'
>     Remove the '-x' option.
>
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs



-- 
Regards,

Zhi Yong Wu

<Prev in Thread] Current Thread [Next in Thread>