[Top] [All Lists]

Re: XFS assertion from truncate. (3.10-rc2)

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: XFS assertion from truncate. (3.10-rc2)
From: Dave Jones <davej@xxxxxxxxxx>
Date: Fri, 24 May 2013 16:16:55 -0400
Cc: Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130524080300.GI24543@dastard>
Mail-followup-to: Dave Jones <davej@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20130522052938.GA2573@xxxxxxxxxx> <20130522055147.GI29466@dastard> <20130522215454.GL29466@dastard> <20130523184948.GA11151@xxxxxxxxxx> <20130523223038.GB24543@dastard> <20130524004906.GA21171@xxxxxxxxxx> <20130524012625.GH24543@dastard> <20130524015219.GA28486@xxxxxxxxxx> <20130524030300.GA30760@xxxxxxxxxx> <20130524080300.GI24543@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, May 24, 2013 at 06:03:00PM +1000, Dave Chinner wrote:

 > xfstest generic/193 is *supposed* to test behaviour of suid/sgid bits
 > and clearing them is various situations.
 > You know what I'm about to say, don't you? The test doesn't test
 > what it thinks it is testing. it puts the destination file in root
 > directory of the xfstests harness, not in the filesystems being
 > tested.

awesome, two bugs for the price of one!

 > So, on all my machines, it runs on ext3 filesystems, never on the
 > ext4, btrfs, xfs, etc filesystems that I'm actually testing.
 > That's beside the point, because it doesn't test truncate behaviour.
 > But at least I know now why my attempts to reproduce the problem
 > didn't work...
 > Right, patch below should fix the problem.

Haven't seen anything out of the ordinary since I applied that,
so I'd call it good.
 > What a frustrating bug. Now, where's my bottle of scotch?

heh, enjoy the weekend.


<Prev in Thread] Current Thread [Next in Thread>