xfs
[Top] [All Lists]

[PATCH V2] xfsprogs: libhandle/Makefile - fix make install-dev

To: xfs@xxxxxxxxxxx
Subject: [PATCH V2] xfsprogs: libhandle/Makefile - fix make install-dev
From: rjohnston@xxxxxxx
Date: Thu, 23 May 2013 08:52:52 -0500
Delivered-to: xfs@xxxxxxxxxxx
References: <20130522205819.586978467@xxxxxxxxxxxxxxxxxxxxxxx>
User-agent: quilt/0.47-15.17.1
The dependency for install-dev: is incorrect "default" and prevents libhandle
from being installed correctly.

After make && make install-dev

  # ls -l /lib64/libhandle* /usr/lib64/libhandle*
  lrwxrwxrwx 1 root root /lib64/libhandle.a -> /usr/lib64/libhandle.a
  lrwxrwxrwx 1 root root /lib64/libhandle.la -> /usr/lib64/libhandle.la
  lrwxrwxrwx 1 root root /lib64/libhandle.so -> libhandle.so.1
  -rw-r--r-- 1 root root /usr/lib64/libhandle.a
  -rw-r--r-- 1 root root /usr/lib64/libhandle.la
  lrwxrwxrwx 1 root root /usr/lib64/libhandle.so -> /lib64/libhandle.so

The shared library /lib64/libhandle.so.1.0.3 is not installed and
the link /lib64/libhandle.so.1 -> libhandle.so.1.0.3 is not created.

Change the dependency for install-dev: to "install" so the install looks like
this.

  # ls -l /lib64/libhandle* /usr/lib64/libhandle*
  lrwxrwxrwx 1 root root /lib64/libhandle.a -> /usr/lib64/libhandle.a
  lrwxrwxrwx 1 root root /lib64/libhandle.la -> /usr/lib64/libhandle.la
  lrwxrwxrwx 1 root root /lib64/libhandle.so -> libhandle.so.1
  lrwxrwxrwx 1 root root /lib64/libhandle.so.1 -> libhandle.so.1.0.3
  -rwxr-xr-x 1 root root /lib64/libhandle.so.1.0.3
  -rw-r--r-- 1 root root /usr/lib64/libhandle.a
  -rw-r--r-- 1 root root /usr/lib64/libhandle.la
  lrwxrwxrwx 1 root root /usr/lib64/libhandle.so -> /lib64/libhandle.so

Signed-off-by: Rich Johnston <rjohnston@xxxxxxx>
--
V1->V2
As Dave pointed out removing the ltdepend would prevent proper rebuilds.
Don't just make the install work ;) correct the dependency for install-dev.

diff --git a/libhandle/Makefile b/libhandle/Makefile
index 865ca22..081a386 100644
--- a/libhandle/Makefile
+++ b/libhandle/Makefile
@@ -22,7 +22,7 @@ include $(BUILDRULES)
 install: default
        $(INSTALL_LTLIB)
 
-install-dev: default
+install-dev: install
        $(INSTALL_LTLIB_DEV)
 
 install-qa: install-dev


<Prev in Thread] Current Thread [Next in Thread>