xfs
[Top] [All Lists]

[PATCH] xfstests: Change mount method for shared/243

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: [PATCH] xfstests: Change mount method for shared/243
From: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
Date: Wed, 22 May 2013 22:27:21 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=3J+zayIZJNUtYTdoXA1O+ArHxYzCWJxRZgDH7PQU21I=; b=aHmCLcQKXXIQdX7ORoFqqTVkmoNvtgwV7e2sm3yHSJaKSKEZ88u832WKABluruj0wY bEtyhRbdk9NyaM1lI8uBbRMlkvGBS+A7U9xKJZhVh8pZUoMyyONNh3WtB7zX8cRTo/FR 3PUclc0h7xcTdoXpQ9nb5mvfKvb59BWnoMwPHFKNdDeF0FYfPWsqRZPRhqhsQ6lNx6Gr PalzHgx8ZNRg4CsMd76NaMxzgB86CgkjD5MahQ6EBWYutKFrQGTYs2X0j5zSC1/e7C66 KucPxA5lBW68+1kCw4FfD+fqelIntG30R31I+9K77PpZs6bmadQlJBEIOqRVJxxldrKn Znrg==
In-reply-to: <20130522012620.GA29466@dastard>
References: <519C14A1.8000009@xxxxxxxxx> <20130522012620.GA29466@dastard>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130509 Thunderbird/17.0.6
Hi!  This patch updates the mount method in xfstests shared/243 
without seeming to change the behavior of the test.  Should this 
patch get a NACK for not being useful, no worries!  There will be 
other opportunities.

The patch was tested with ext4, with and without external journals. 
It was also tested on XFS with an external logdev.  The MOUNT_OPTIONS 
for the ext4 tests included '-o barrier=1' and '-o barrier=0'.  The 
test results varied on ext4 with an external journal, but the 
results shown by /proc/mounts was OK.  [barrier=1 causes a failed 
test, barrier=0 succeeds, both in the original and patched test.]

>From 8762f621a5fb9556fa96ec289bceffc4fcc844f3 Mon Sep 17 00:00:00 2001
From: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
Date: Wed, 22 May 2013 20:57:56 -0400
Subject: [PATCH] xfstests: Change mount method for shared/243

Change the mount invocations in shared/243 to use the built-in
_test_mount function of xfstests.  This was done as part of a
clean-up recommendation.  Currently, only ext4 file systems are
affected by this change.

Signed-off-by: Michael L. Semon <mlsemon35@xxxxxxxxx>
---
 tests/shared/243 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/shared/243 b/tests/shared/243
index e0f2db2..b3eb025 100755
--- a/tests/shared/243
+++ b/tests/shared/243
@@ -108,7 +108,7 @@ _check_ext4_eof_flag()
     fi
 
     # Mount the ${TEST_DEV}
-    mount ${TEST_DEV} -t ${FSTYP} ${TEST_DIR}
+    _test_mount
   fi
 }
 
-- 
1.8.2


<Prev in Thread] Current Thread [Next in Thread>