xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: libhandle/Makefile - fix make install

To: rjohnston@xxxxxxx
Subject: Re: [PATCH] xfsprogs: libhandle/Makefile - fix make install
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 23 May 2013 08:16:02 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130522205819.586978467@xxxxxxxxxxxxxxxxxxxxxxx>
References: <20130522205819.586978467@xxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, May 22, 2013 at 03:58:19PM -0500, rjohnston@xxxxxxx wrote:
> In the default section of libhandle/Makefile, ltdepend prevented
> libhandle.so from being installed properly so remove it.
> 
> Signed-off-by: Rich Johnston <rjohnston@xxxxxxx>
> --
> diff --git a/libhandle/Makefile b/libhandle/Makefile
> index 865ca22..2f39173 100644
> --- a/libhandle/Makefile
> +++ b/libhandle/Makefile
> @@ -15,7 +15,7 @@ LTLDFLAGS += -Wl,--version-script,libhandle.sym
>  CFILES = handle.c jdm.c
>  LSRCFILES = libhandle.sym
>  
> -default: ltdepend $(LTLIBRARY)
> +default: $(LTLIBRARY)

PLease explain how removing the makefile build dependency generation
fixes a library install problem. This, AFAICT, will just break
rebuild detection of the library when we modify srouce files.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>