xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: libhandle/Makefile - fix make install

To: rjohnston@xxxxxxx
Subject: Re: [PATCH] xfsprogs: libhandle/Makefile - fix make install
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 22 May 2013 16:22:30 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130522205819.586978467@xxxxxxxxxxxxxxxxxxxxxxx>
References: <20130522205819.586978467@xxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130509 Thunderbird/17.0.6
On 5/22/13 3:58 PM, rjohnston@xxxxxxx wrote:
> In the default section of libhandle/Makefile, ltdepend prevented
> libhandle.so from being installed properly so remove it.

Can you explain how it prevented it?

[sandeen@sandeen xfsprogs]$ grep ltdepend */Makefile
libdisk/Makefile:default: ltdepend $(LTLIBRARY)
libhandle/Makefile:default: ltdepend $(LTLIBRARY)
libxcmd/Makefile:default: ltdepend $(LTLIBRARY)
libxfs/Makefile:default: crc32selftest ltdepend $(LTLIBRARY)
libxlog/Makefile:default: ltdepend $(LTLIBRARY)

seems to exist in every subdir, why is this one causing trouble?

/me goes off to dig around in makefiles


> Signed-off-by: Rich Johnston <rjohnston@xxxxxxx>
> --
> diff --git a/libhandle/Makefile b/libhandle/Makefile
> index 865ca22..2f39173 100644
> --- a/libhandle/Makefile
> +++ b/libhandle/Makefile
> @@ -15,7 +15,7 @@ LTLDFLAGS += -Wl,--version-script,libhandle.sym
>  CFILES = handle.c jdm.c
>  LSRCFILES = libhandle.sym
>  
> -default: ltdepend $(LTLIBRARY)
> +default: $(LTLIBRARY)
>  
>  include $(BUILDRULES)
>  
> 
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>