xfs
[Top] [All Lists]

Re: generic/258 questions (mount issue)...

To: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
Subject: Re: generic/258 questions (mount issue)...
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 22 May 2013 09:10:33 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <519C3596.7080109@xxxxxxxxx>
References: <519C14A1.8000009@xxxxxxxxx> <20130522012620.GA29466@dastard> <519C3596.7080109@xxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130509 Thunderbird/17.0.6
On 5/21/13 10:03 PM, Michael L. Semon wrote:

...

> From 7dc0667e1f8cd1c98f15ebf412dd0f038b55306e Mon Sep 17 00:00:00 2001
> From: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
> Date: Tue, 21 May 2013 22:50:59 -0400
> Subject: [PATCH] Change mount method for generic/258
> 
> Use the built-in _test_mount function from xfstests so it will use
> the correct mount options for xfstests.  The script used a simple
> umount-and-mount sequence, which caused a test failure on an XFS
> filesystem that used both realtime and external log devices.
> 
> Signed-off-by: Michael L. Semon <mlsemon35@xxxxxxxxx>

Thanks, this was my fault  :(

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxx>

Want to consider dave's other suggestions in another patch?

> There are a handful of other tests that also unmount the TEST_DEV.
> Perhaps adding a _test_umount() wrapper to common/rc (similar to
> _scratch_umount) would be best. At least shared/243 needs the same
> _test_mount treatment as this test.

Eternal git-log fame would be yours.  ;)

-Eric

> ---
>  tests/generic/258 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/258 b/tests/generic/258
> index fb091ae..3aeb5ce 100755
> --- a/tests/generic/258
> +++ b/tests/generic/258
> @@ -62,7 +62,7 @@ fi
>  # unmount, remount, and check the timestamp
>  echo "Remounting to flush cache"
>  umount $TEST_DEV
> -mount $TEST_DEV $TEST_DIR
> +_test_mount
>  
>  # Should yield -315593940 (prior to epoch)
>  echo "Testing for negative seconds since epoch"
> 

<Prev in Thread] Current Thread [Next in Thread>