xfs
[Top] [All Lists]

Re: generic/258 questions (mount issue)...

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: generic/258 questions (mount issue)...
From: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
Date: Tue, 21 May 2013 23:03:50 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=1MBqhlR4mLPUcBOHbt0UT9oQUYUulNjXe1GqJuJne8Q=; b=ya443tisDRxXIOVQBA2oNAhrLqPL5PvdHZmMyMVLzTYKIDFDzb9bp8faV4+aXb/Hqq F5yCXSf/eFZZ1uq0cKU1DQAz61wQQUsCSrOAiHelKOEaba8JtEB38fxGqnxhKfSN1/on nuSMa5z25IyXPNk/jBFXmnrK6moty2eZM5lI6oRHv1svmbil9gXpJ5nbA6ev581IqWKb Pu4HC3GF/3jPh1Q82k64wN3s3XqddKkpodaA+rt8gqWCagaAxrKDkL4hJE544lluWPb5 mccDQtTzWpUQEGmZFUJOsIuxXJldMO6CisUCUeyJG1geHVmCq69wJchtqRp9R1ABgnok r+EA==
In-reply-to: <20130522012620.GA29466@dastard>
References: <519C14A1.8000009@xxxxxxxxx> <20130522012620.GA29466@dastard>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130509 Thunderbird/17.0.6
On 05/21/2013 09:26 PM, Dave Chinner wrote:
> On Tue, May 21, 2013 at 08:43:13PM -0400, Michael L. Semon wrote:
>> Hi!  When using xfstests generic/258 with along with $TEST_RTDEV
>> $TEST_LOGDEV, it tends to scream bloody murder about corrupted
>> partitions and such.  In fact, the commands in the test seem to do
>> the right thing when executed by hand.  So once again, I grasped for
>> straws and came up with this:
>>
>> --- xfstests/tests/generic/258.orig  2013-05-21 20:19:38.430754829 -0400
>> +++ xfstests/tests/generic/258       2013-05-21 20:10:11.509021368 -0400
>> @@ -62,7 +62,7 @@
>>  # unmount, remount, and check the timestamp
>>  echo "Remounting to flush cache"
>>  umount $TEST_DEV
>> -mount $TEST_DEV $TEST_DIR
>> +_test_mount
>>
>>  # Should yield -315593940 (prior to epoch)
>>  echo "Testing for negative seconds since epoch"
>>
>> My questions are these:
>>
>> 1) Was there a better way to do this?
> 
> No, your change is correct. Can you clean up the description of the
> problem you had and add a Signed-off-by?
> 
>> 2) Not knowing the policy on umounting $TEST_DEV, could this have
>> been a test for $SCRATCH_DEV?
> 
> There are a handful of other tests that also unmount the TEST_DEV.
> Perhaps adding a _test_umount() wrapper to common/rc (similar to
> _scratch_umount) would be best. At least shared/243 needs the same
> _test_mount treatment as this test.
> 
> Cheers,
> 
> Dave.
> 

This is my first attempt at doing a `git format-patch --stdout`.  
Hopefully, this is somewhat more presentable to git.  Comments and 
brow-beating are welcome.

Thanks!

Michael

>From 7dc0667e1f8cd1c98f15ebf412dd0f038b55306e Mon Sep 17 00:00:00 2001
From: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
Date: Tue, 21 May 2013 22:50:59 -0400
Subject: [PATCH] Change mount method for generic/258

Use the built-in _test_mount function from xfstests so it will use
the correct mount options for xfstests.  The script used a simple
umount-and-mount sequence, which caused a test failure on an XFS
filesystem that used both realtime and external log devices.

Signed-off-by: Michael L. Semon <mlsemon35@xxxxxxxxx>
---
 tests/generic/258 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/258 b/tests/generic/258
index fb091ae..3aeb5ce 100755
--- a/tests/generic/258
+++ b/tests/generic/258
@@ -62,7 +62,7 @@ fi
 # unmount, remount, and check the timestamp
 echo "Remounting to flush cache"
 umount $TEST_DEV
-mount $TEST_DEV $TEST_DIR
+_test_mount
 
 # Should yield -315593940 (prior to epoch)
 echo "Testing for negative seconds since epoch"
-- 
1.8.2


<Prev in Thread] Current Thread [Next in Thread>