xfs
[Top] [All Lists]

Re: generic/258 questions (mount issue)...

To: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
Subject: Re: generic/258 questions (mount issue)...
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 22 May 2013 11:26:21 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <519C14A1.8000009@xxxxxxxxx>
References: <519C14A1.8000009@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, May 21, 2013 at 08:43:13PM -0400, Michael L. Semon wrote:
> Hi!  When using xfstests generic/258 with along with $TEST_RTDEV
> $TEST_LOGDEV, it tends to scream bloody murder about corrupted
> partitions and such.  In fact, the commands in the test seem to do
> the right thing when executed by hand.  So once again, I grasped for
> straws and came up with this:
> 
> --- xfstests/tests/generic/258.orig   2013-05-21 20:19:38.430754829 -0400
> +++ xfstests/tests/generic/258        2013-05-21 20:10:11.509021368 -0400
> @@ -62,7 +62,7 @@
>  # unmount, remount, and check the timestamp
>  echo "Remounting to flush cache"
>  umount $TEST_DEV
> -mount $TEST_DEV $TEST_DIR
> +_test_mount
> 
>  # Should yield -315593940 (prior to epoch)
>  echo "Testing for negative seconds since epoch"
> 
> My questions are these:
> 
> 1) Was there a better way to do this?

No, your change is correct. Can you clean up the description of the
problem you had and add a Signed-off-by?

> 2) Not knowing the policy on umounting $TEST_DEV, could this have
> been a test for $SCRATCH_DEV?

There are a handful of other tests that also unmount the TEST_DEV.
Perhaps adding a _test_umount() wrapper to common/rc (similar to
_scratch_umount) would be best. At least shared/243 needs the same
_test_mount treatment as this test.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>