xfs
[Top] [All Lists]

Re: XFS assertion from truncate. (3.10-rc2)

To: Dave Jones <davej@xxxxxxxxxx>, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: XFS assertion from truncate. (3.10-rc2)
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 22 May 2013 10:16:03 +1000
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130522000803.GA19891@xxxxxxxxxx>
References: <20130521225257.GA12713@xxxxxxxxxx> <20130521233429.GW29466@dastard> <20130521234016.GB14347@xxxxxxxxxx> <20130521235410.GY29466@dastard> <20130522000803.GA19891@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, May 21, 2013 at 08:08:03PM -0400, Dave Jones wrote:
> On Wed, May 22, 2013 at 09:54:10AM +1000, Dave Chinner wrote:
>  > On Tue, May 21, 2013 at 07:40:16PM -0400, Dave Jones wrote:
>  > > On Wed, May 22, 2013 at 09:34:29AM +1000, Dave Chinner wrote:
>  > >  > On Tue, May 21, 2013 at 06:52:57PM -0400, Dave Jones wrote:
>  > >  > > [  464.210598] XFS: Assertion failed: (mask & 
> (ATTR_MODE|ATTR_UID|ATTR_GID|ATTR_ATIME|ATTR_ATIME_SET| 
> ATTR_MTIME_SET|ATTR_KILL_SUID|ATTR_KILL_SGID| ATTR_KILL_PRIV|ATTR_TIMES_SET)) 
> == 0, file: fs/xfs/xfs_iops.c, line: 719
>  > >  > 
>  > >  > Never seen that fire before, but this is why we have ASSERT()s like
>  > >  > this - we're being handed something by the VFS we don't expect...
>  > >  > 
>  > >  > Can you give me some context of the file permissions before the
>  > >  > syscall and what the syscall parameters are? i.e. is this likely to
>  > >  > be trying to strip SUID/SGID during the truncate operation?
>  > > 
>  > > no idea tbh. Is there something I can add to that assert to dump
>  > > which file it was triggered by ?
>  > 
>  > Convert the assert to a if (), and then in the body do something
>  > like:
>  > 
>  >    if (mask & (...) {
>  >            char buf[MAX_PATHLEN];
>  > 
>  >            d_path(VFS_I(ip)->i_dentry, buf, MAXPATHLEN);
>  >            xfs_warn(mp, "%s: mask 0x%x mismatch on file %s\n",
>  >                     __func__, mask, buf);
>  >            ASSERT(0);
>  >    }
> 
> fs/xfs/xfs_iops.c: In function âxfs_setattr_sizeâ:
> fs/xfs/xfs_iops.c:723:17: error: incompatible type for argument 1 of âd_pathâ
>                  d_path(VFS_I(ip)->i_dentry, buf, MAXPATHLEN);
>                  ^

Oh, sorry, dentry_path() is the version that takes a dentry as the
first parameter. I always get the two confused...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>