xfs
[Top] [All Lists]

Re: XFS assertion from truncate. (3.10-rc2)

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: XFS assertion from truncate. (3.10-rc2)
From: Dave Jones <davej@xxxxxxxxxx>
Date: Tue, 21 May 2013 20:08:03 -0400
Cc: Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130521235410.GY29466@dastard>
Mail-followup-to: Dave Jones <davej@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20130521225257.GA12713@xxxxxxxxxx> <20130521233429.GW29466@dastard> <20130521234016.GB14347@xxxxxxxxxx> <20130521235410.GY29466@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, May 22, 2013 at 09:54:10AM +1000, Dave Chinner wrote:
 > On Tue, May 21, 2013 at 07:40:16PM -0400, Dave Jones wrote:
 > > On Wed, May 22, 2013 at 09:34:29AM +1000, Dave Chinner wrote:
 > >  > On Tue, May 21, 2013 at 06:52:57PM -0400, Dave Jones wrote:
 > >  > > [  464.210598] XFS: Assertion failed: (mask & 
 > > (ATTR_MODE|ATTR_UID|ATTR_GID|ATTR_ATIME|ATTR_ATIME_SET| 
 > > ATTR_MTIME_SET|ATTR_KILL_SUID|ATTR_KILL_SGID| 
 > > ATTR_KILL_PRIV|ATTR_TIMES_SET)) == 0, file: fs/xfs/xfs_iops.c, line: 719
 > >  > 
 > >  > Never seen that fire before, but this is why we have ASSERT()s like
 > >  > this - we're being handed something by the VFS we don't expect...
 > >  > 
 > >  > Can you give me some context of the file permissions before the
 > >  > syscall and what the syscall parameters are? i.e. is this likely to
 > >  > be trying to strip SUID/SGID during the truncate operation?
 > > 
 > > no idea tbh. Is there something I can add to that assert to dump
 > > which file it was triggered by ?
 > 
 > Convert the assert to a if (), and then in the body do something
 > like:
 > 
 >      if (mask & (...) {
 >              char buf[MAX_PATHLEN];
 > 
 >              d_path(VFS_I(ip)->i_dentry, buf, MAXPATHLEN);
 >              xfs_warn(mp, "%s: mask 0x%x mismatch on file %s\n",
 >                       __func__, mask, buf);
 >              ASSERT(0);
 >      }

fs/xfs/xfs_iops.c: In function âxfs_setattr_sizeâ:
fs/xfs/xfs_iops.c:723:17: error: incompatible type for argument 1 of âd_pathâ
                 d_path(VFS_I(ip)->i_dentry, buf, MAXPATHLEN);
                 ^
In file included from include/linux/fs.h:8:0,
                 from include/linux/genhd.h:65,
                 from include/linux/blkdev.h:9,
                 from fs/xfs/xfs_linux.h:45,
                 from fs/xfs/xfs.h:32,
                 from fs/xfs/xfs_iops.c:18:
include/linux/dcache.h:338:14: note: expected âconst struct path *â but 
argument is of type âstruct hlist_headâ
 extern char *d_path(const struct path *, char *, int);
              ^


        Dave

<Prev in Thread] Current Thread [Next in Thread>