Re: [PATCH 07/14] xfs: xfs_attr_shortform_allfit() does not handle attr3

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 07/14] xfs: xfs_attr_shortform_allfit() does not handle attr3 format.
From:	Ben Myers <bpm@xxxxxxx>
Date:	Mon, 20 May 2013 16:52:27 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1369007481-15185-8-git-send-email-david@xxxxxxxxxxxxx>
References:	<1369007481-15185-1-git-send-email-david@xxxxxxxxxxxxx> <1369007481-15185-8-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

On Mon, May 20, 2013 at 09:51:14AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xfstests generic/117 fails with:
> 
> XFS: Assertion failed: leaf->hdr.info.magic == 
> cpu_to_be16(XFS_ATTR_LEAF_MAGIC)
> 
> indicating a function that does not handle the attr3 format
> correctly. Fix it.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.  Applied.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 05/14] xfs: fix missing KM_NOFS tags to keep lockdep happy, (continued) Re: [PATCH 05/14] xfs: fix missing KM_NOFS tags to keep lockdep happy, Dave Chinner [PATCH 04/14] xfs: avoid nesting transactions in xfs_qm_scall_setqlim(), Dave Chinner Re: [PATCH 04/14] xfs: avoid nesting transactions in xfs_qm_scall_setqlim(), Brian Foster Re: [PATCH 04/14] xfs: avoid nesting transactions in xfs_qm_scall_setqlim(), Dave Chinner [PATCH 04/14 V2] xfs: avoid nesting transactions in xfs_qm_scall_setqlim(), Dave Chinner Re: [PATCH 04/14 V2] xfs: avoid nesting transactions in xfs_qm_scall_setqlim(), Brian Foster [PATCH 10/14] xfs: remote attribute read too short, Dave Chinner Re: [PATCH 10/14] xfs: remote attribute read too short, Ben Myers [PATCH 12/14] xfs: correctly map remote attr buffers during removal, Dave Chinner [PATCH 07/14] xfs: xfs_attr_shortform_allfit() does not handle attr3 format., Dave Chinner Re: [PATCH 07/14] xfs: xfs_attr_shortform_allfit() does not handle attr3 format., Ben Myers <= [PATCH 06/14] xfs: xfs_da3_node_read_verify() doesn't handle XFS_ATTR3_LEAF_MAGIC, Dave Chinner Re: [PATCH 06/14] xfs: xfs_da3_node_read_verify() doesn't handle XFS_ATTR3_LEAF_MAGIC, Ben Myers [PATCH 02/14] xfs: fix rounding in xfs_free_file_space, Dave Chinner Re: [PATCH 02/14] xfs: fix rounding in xfs_free_file_space, Brian Foster [PATCH 08/14] xfs: remote attribute allocation may be contiguous, Dave Chinner Re: [PATCH 08/14] xfs: remote attribute allocation may be contiguous, Brian Foster Re: [PATCH 08/14] xfs: remote attribute allocation may be contiguous, Ben Myers Re: [PATCH 08/14] xfs: remote attribute allocation may be contiguous, Dave Chinner [PATCH 13/14] xfs: fully initialise temp leaf in xfs_attr3_leaf_unbalance, Dave Chinner [PATCH 14/14] xfs: fully initialise temp leaf in xfs_attr3_leaf_compact, Dave Chinner

Previous by Date:	ÐÐÑ ÐÐÐÐ ÑÐÐÑÑÑ ÐÑÐÐÐÐÑÐÐ ÐÐÐÑÑÑ Ñ ÑÐÐÐÐ., ÐÐÐÐÑÐÐÐÑ Tayeer
Next by Date:	Re: [PATCH 08/14] xfs: remote attribute allocation may be contiguous, Ben Myers
Previous by Thread:	[PATCH 07/14] xfs: xfs_attr_shortform_allfit() does not handle attr3 format., Dave Chinner
Next by Thread:	[PATCH 06/14] xfs: xfs_da3_node_read_verify() doesn't handle XFS_ATTR3_LEAF_MAGIC, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]